Removed custom logger #2978
Merged
Removed custom logger #2978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssbarnea
requested review from
decentral1se,
apatard,
greg-hellings and
tadeboro
tadeboro
reviewed
Nov 18, 2020
There was a problem hiding this comment.
I found no major issues in the code. I do have two minor questions, but that is it. Once we resolve them, things are good as far as I am concerned.
On an unrelated note: I also noticed that the BakedCommand is a data class during the review. Which all fine and dandy, but those are only available in python >= 3.7, and Molecule advertises compatibility with 3.6. Not sure why tests did not catch this. Unfortunately, I have no time to investigate right now,
Molecule no longer uses a custom logger class and we make use of the standard python logger class. This change replaces logger.success() and logger.out() with logger.info() calls.
|
@tadeboro There is a bug that we missed to add dataclasses for py36 but our testing failed to spot it because another dependency did install it. I will add a patch just to be sure. |
abtreece
added a commit
to ansible-community/molecule-inspec
that referenced
this pull request
Nov 20, 2020
The custom logger class has been removed from Molecule and thus we must remove those references from the plugin. ansible/molecule#2978
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Molecule no longer uses a custom logger class and we make use of the standard python logger class.
This change replaces
logger.success()andlogger.out()withlogger.info()calls.