Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PIP_OPTs for python-builder-image #211

Closed
pabelanger opened this issue Apr 30, 2021 · 5 comments
Closed

Support PIP_OPTs for python-builder-image #211

pabelanger opened this issue Apr 30, 2021 · 5 comments
Labels
enhancement New feature or request

Comments

@pabelanger
Copy link
Contributor

We added support to python-builder-image, which allows a user to pass pip options via PIP_OPTs:

ansible/python-builder-image#34

In the case of downstream builds, we set --no-build-isolation for reproducible builds. Additionally, it would allow upstream users to pass:

--no-binary :all:

Which disabled use of pre-compiled wheels, again getting upstream builds closer to downstream / offline supported.

@AlanCoding
Copy link
Member

How would users pass this option to ansible-builder? Would it be in the execution environment definition?

@AlanCoding AlanCoding added the enhancement New feature or request label May 25, 2021
@pabelanger
Copy link
Contributor Author

I imagined it working the same way we did the galaxy opts setting

@AlanCoding
Copy link
Member

so a build arg.

The assemble script also takes, in some sense, CONSTRAINTS, PACKAGES, and others. I don't fully understand those options.

In my imagination, this would follow an ARG and then ENV pattern in the Containerfile. That wouldn't get messy if we add more later.

@tanganellilore
Copy link
Contributor

@AlanCoding @Shrews I created a PR that will add this param. In the PR I wrote why we need this tipe of arg

Thanks

@Shrews
Copy link
Contributor

Shrews commented Apr 5, 2023

I'm going to go ahead and close this. We just merged support for a new EE format that has features that would allow you highly customize any of the builder build phases (e.g., the new additional_build_steps section).

@Shrews Shrews closed this as completed Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants