Small change to properly test containers #801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should depend on the container build job, not buildset registry. This way, we pull down the proper pre-merged container for testing changes. Signed-off-by: Paul Belanger <pabelanger@redhat.com>
shanemcd
approved these changes
Aug 20, 2021
Shrews
approved these changes
Aug 20, 2021
![ansible-zuul[bot]](https://avatars.githubusercontent.com/in/27800?s=60&v=4){kind=small}
ansible-zuul bot
added a commit
that referenced
this pull request
Sep 27, 2021
[release_2.0] Backport integration test Backports of: PR #790 - Add custom integration python job PR #796 - Migrate container jobs to centos-8-stream nodeset PR #797 - Tune tox.ini PR #798 - Rework bindep.txt files PR #801 - Small change to properly test containers Reviewed-by: Shane McDonald <me@shanemcd.com> Reviewed-by: None <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should depend on the container build job, not buildset registry. This
way, we pull down the proper pre-merged container for testing changes.
Signed-off-by: Paul Belanger pabelanger@redhat.com