Ensure that ansible-runner worker --worker-info Returns Unique IDs #854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uld be duplicated across several nodes
|
recheck |
samdoran
reviewed
Sep 29, 2021
samdoran
reviewed
Sep 29, 2021
|
I just looked at the existing tests and there are no tests at all for At a minimum, we need tests for the net new code. It would be really great to create tests for the existing function before changing it as well. |
shanemcd
reviewed
Sep 30, 2021
shanemcd
reviewed
Sep 30, 2021
shanemcd
reviewed
Sep 30, 2021
Change both functions to accept a path to the UUID file, defaulting to an immutable Path object. This allows easier testing without mocking. Change function names to refelct that one sets the UUID (_set_uuid()), always overwriting any existing file while the other function, ensure_uuid(), will only set the UUID if the UUID file does not exist. Add unit tests.
samdoran
reviewed
Oct 4, 2021
shanemcd
changed the title
shanemcd
approved these changes
Oct 4, 2021
While Path objects are immutable, the previous default had two main problems:
1. Function defaults are processed on import. The previous default meant that
quite a bit of work was done just when the function was imported.
2. Since the value of Path.home() varies depending on the user invoking the
function, the means the function default is not consistent.
Using None then setting the default value within the function is a bit noisier,
but addresses the two issues above.
Add parameters for accepting mode. Add tests for ensuring the mode is set properly.
samdoran
approved these changes
Oct 5, 2021
![ansible-zuul[bot]](https://avatars.githubusercontent.com/in/27800?s=60&v=4){kind=small}
|
recheck |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #850
In certain cases (e.g. when utilizing VMs spun up with IBM Cloud), the provided machine ID for each node will sometimes be identical; this code change would make it so that we purposefully generate a brand new UUID for each node and store it in a file for retrieval (the details of this file and its location are still TBD); this will ensure an actually unique UUID for each worker node.