Wrong search paths with include_role

[torgiren]

ISSUE TYPE

• Bug Report (propably)

COMPONENT NAME

dynamic includes

ANSIBLE VERSION

ansible 2.5.0 (devel e3b5be0887) last updated 2018/01/12 07:53:31 (GMT +200)
  config file = None
  configured module search path = [u'/home/torgiren/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /tmp/ansible/lib/ansible
  executable location = /tmp/ansible/bin/ansible
  python version = 2.7.14 (default, Nov 26 2017, 14:35:36) [GCC 5.4.0]

same on 2.4.0

CONFIGURATION

default configuration
ansible-config dump --only-changed - empty result

OS / ENVIRONMENT

Linux, but it isn't important

SUMMARY

include path are wrong, then using include_roles.
Ansible does not search for tasks in role that use include_tasks.
When we use include_role, the search path is limited only to parent roles.
In the example below, we have roles:
top - which include_role role one
one - which include_role role two
two - which dependency role three
three - which include_task file in her tasks/

when using include_role, included_tasks are search only in one/tasks and two/tasks.
It's bug in my opinion, because it should search in three/tasks as well. (and maybe in top/tasks?)

STEPS TO REPRODUCE

roles/top/tasks/main.yml

- include_role:
    name: one

roles/one/tasks/main.yml

- debug:
    msg: "one"

- include_role:
    name: two

roles/two/tasks/main.yml

- debug:
    msg: "two"

roles/two/meta/main.yml

dependencies:
- three

roles/three/tasks/main.yml

- debug:
    msg: "three"

- include_tasks: my.yml

roles/three/tasks/my.yml

- debug:
    msg: "it my"

playbook_a.yml

- hosts:
    localhost
  roles:
  - three

playbook_b.yml

- hosts:
    localhost
  roles:
  - top

EXPECTED RESULTS

ansible-playbook -i inventory playbook_a.yml                           

PLAY [localhost] *****************************************************************************

TASK [Gathering Facts] ***********************************************************************
ok: [localhost]

TASK [three : debug] *************************************************************************
ok: [localhost] => {
    "attempts": 1, 
    "msg": "three"
}

TASK [three : include_tasks] *****************************************************************
included: /tmp/uuy/roles/three/tasks/my.yml for localhost

TASK [three : debug] *************************************************************************
ok: [localhost] => {
    "attempts": 1, 
    "msg": "it my"
}

PLAY RECAP ***********************************************************************************
localhost                  : ok=4    changed=0    unreachable=0    failed=0   

ansible-playbook -i inventory playbook_b.yml

PLAY [localhost] *****************************************************************************

TASK [Gathering Facts] ***********************************************************************
ok: [localhost]

TASK [top : include_role] ********************************************************************

TASK [one : debug] ***************************************************************************
ok: [localhost] => {
    "attempts": 1, 
    "msg": "one"
}

TASK [one : include_role] ********************************************************************

TASK [three : debug] *************************************************************************
ok: [localhost] => {
    "attempts": 1, 
    "msg": "three"
}

TASK [three : include_tasks] *****************************************************************
included: /tmp/uuy/roles/three/tasks/my.yml for localhost

TASK [three : debug] *************************************************************************
ok: [localhost] => {
    "attempts": 1, 
    "msg": "it my"
}

TASK [two : debug] ***************************************************************************
ok: [localhost] => {
    "attempts": 1, 
    "msg": "two"
}

PLAY RECAP ***********************************************************************************
localhost                  : ok=6    changed=0    unreachable=0    failed=0   

ACTUAL RESULTS

 ansible-playbook -i inventory playbook_a.yml

PLAY [localhost] ******************************************************************************************************************************************************************************

TASK [Gathering Facts] ************************************************************************************************************************************************************************
ok: [localhost]

TASK [three : debug] **************************************************************************************************************************************************************************
ok: [localhost] => {
    "attempts": 1, 
    "msg": "three"
}

TASK [three : include_tasks] ******************************************************************************************************************************************************************
included: /tmp/uuy/roles/three/tasks/my.yml for localhost

TASK [three : debug] **************************************************************************************************************************************************************************
ok: [localhost] => {
    "attempts": 1, 
    "msg": "it my"
}

PLAY RECAP ************************************************************************************************************************************************************************************
localhost                  : ok=4    changed=0    unreachable=0    failed=0   

 ansible-playbook -i inventory playbook_b.yml

PLAY [localhost] ******************************************************************************************************************************************************************************

TASK [Gathering Facts] ************************************************************************************************************************************************************************
ok: [localhost]

TASK [top : include_role] *********************************************************************************************************************************************************************

TASK [one : debug] ****************************************************************************************************************************************************************************
ok: [localhost] => {
    "attempts": 1, 
    "msg": "one"
}

TASK [one : include_role] *********************************************************************************************************************************************************************

TASK [three : debug] **************************************************************************************************************************************************************************
ok: [localhost] => {
    "attempts": 1, 
    "msg": "three"
}

TASK [three : include_tasks] ******************************************************************************************************************************************************************
fatal: [localhost]: FAILED! => {"reason": "Unable to retrieve file contents\nCould not find or access '/tmp/uuy/my.yml'"}
        to retry, use: --limit @/tmp/uuy/playbook_b.retry

PLAY RECAP ************************************************************************************************************************************************************************************
localhost                  : ok=3    changed=0    unreachable=0    failed=1   

and with strace, we can see:

strace -f -e file ansible-playbook -i inventory playbook_b.yml 2>&1|grep my.yml 
[pid 19037] stat("/tmp/uuy/roles/two/tasks/my.yml", 0x7fff64d17730) = -1 ENOENT (No such file or directory)
[pid 19037] stat("/tmp/uuy/roles/two/tasks/my.yml", 0x7fff64d17730) = -1 ENOENT (No such file or directory)
[pid 19037] stat("/tmp/uuy/roles/two/tasks/my.yml", 0x7fff64d17730) = -1 ENOENT (No such file or directory)
[pid 19037] stat("/tmp/uuy/tasks/my.yml", 0x7fff64d17730) = -1 ENOENT (No such file or directory)
[pid 19037] stat("/tmp/uuy/roles/two/my.yml", 0x7fff64d17730) = -1 ENOENT (No such file or directory)
[pid 19037] stat("/tmp/uuy/tasks/my.yml", 0x7fff64d17730) = -1 ENOENT (No such file or directory)
[pid 19037] stat("/tmp/uuy/my.yml", 0x7fff64d17730) = -1 ENOENT (No such file or directory)
[pid 19037] stat("/tmp/uuy/my.yml", 0x7fff64d17930) = -1 ENOENT (No such file or directory)
[pid 19037] stat("/tmp/uuy/roles/one/tasks/my.yml", 0x7fff64d17730) = -1 ENOENT (No such file or directory)
[pid 19037] stat("/tmp/uuy/roles/one/tasks/my.yml", 0x7fff64d17730) = -1 ENOENT (No such file or directory)
[pid 19037] stat("/tmp/uuy/roles/one/tasks/my.yml", 0x7fff64d17730) = -1 ENOENT (No such file or directory)
[pid 19037] stat("/tmp/uuy/tasks/my.yml", 0x7fff64d17730) = -1 ENOENT (No such file or directory)
[pid 19037] stat("/tmp/uuy/roles/one/my.yml", 0x7fff64d17730) = -1 ENOENT (No such file or directory)
[pid 19037] stat("/tmp/uuy/tasks/my.yml", 0x7fff64d17730) = -1 ENOENT (No such file or directory)
[pid 19037] stat("/tmp/uuy/my.yml", 0x7fff64d17730) = -1 ENOENT (No such file or directory)
[pid 19037] stat("/tmp/uuy/my.yml", 0x7fff64d17930) = -1 ENOENT (No such file or directory)
[pid 19037] stat("/tmp/uuy/my.yml", 0x7fff64d17330) = -1 ENOENT (No such file or directory)
fatal: [localhost]: FAILED! => {"reason": "Unable to retrieve file contents\nCould not find or access '/tmp/uuy/my.yml'"}

[ansibot]

Files identified in the description:
None

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

[mkrizek]

cc @bcoca

[torgiren]

look like it's fixed