FIX: multiple nested tasks include levels #35165

kiorky · 2018-01-22T01:05:22Z

I'm splitting the #32565 PR on multiple more isolated PR as it may be easier to accept/check in in core.

ISSUE TYPE

Bug Report

COMPONENT NAME

include_tasks

ANSIBLE VERSION

2.4
devel

CONFIGURATION

standard

OS / ENVIRONMENT

ubuntu lts

SUMMARY

See 4f97013cabc79cba669090b9a7d2a13bdbf34453

STEPS TO REPRODUCE

See 4f97013cabc79cba669090b9a7d2a13bdbf34453

EXPECTED RESULTS

included tasks find file


Running include_role_nested integration test script
Run command: ./runme.sh -v
+ ansible-playbook -i../../inventory nested.yml -v
Using /srv/corpusops/corpusops.bootstrap/venv/src/ansible/test/integration/integration.cfg as config file

PLAY [verify that multiple level of nested statements and  include+meta doesnt mess included files mecanisms] *****************************************************************************************************************************************************************

TASK [Gathering Facts] ********************************************************************************************************************************************************************************************************************************************************
ok: [testhost]

TASK [include_tasks] **********************************************************************************************************************************************************************************************************************************************************
included: /srv/corpusops/corpusops.bootstrap/venv/src/ansible/test/integration/targets/include_role_nested/tasks/nested/nested.yml for testhost

TASK [include_tasks] **********************************************************************************************************************************************************************************************************************************************************
included: /srv/corpusops/corpusops.bootstrap/venv/src/ansible/test/integration/targets/include_role_nested/./tasks/nested/../../nestedtasks/nested/nested.yml for testhost

TASK [include_role] ***********************************************************************************************************************************************************************************************************************************************************

TASK [nested/test_nested_dep_role : include_tasks] ****************************************************************************************************************************************************************************************************************************
included: /srv/corpusops/corpusops.bootstrap/venv/src/ansible/test/integration/targets/include_role_nested/nested/nested/test_nested_dep_role/tasks/./runc.yml for testhost

TASK [nested/test_nested_dep_role : debug] ************************************************************************************************************************************************************************************************************************************
ok: [testhost] => {
    "msg": "from test_nested_dep_role"
}

TASK [nested/test_nested_dep_role : include_role] *****************************************************************************************************************************************************************************************************************************

TASK [nested/nested/test_nested_dep_role2b : include_tasks] *******************************************************************************************************************************************************************************************************************
included: /srv/corpusops/corpusops.bootstrap/venv/src/ansible/test/integration/targets/include_role_nested/nested/nested/nested/test_nested_dep_role2b/tasks/./runf.yml for testhost

TASK [nested/nested/test_nested_dep_role2b : command] *************************************************************************************************************************************************************************************************************************
changed: [testhost] => {"changed": true, "cmd": "echo from deprole2b", "delta": "0:00:00.100271", "end": "2018-01-19 21:28:28.678150", "rc": 0, "start": "2018-01-19 21:28:28.577879", "stderr": "", "stderr_lines": [], "stdout": "from deprole2b", "stdout_lines": ["from deprole2b"]}

TASK [nested/nested/test_nested_dep_role2a : include_tasks] *******************************************************************************************************************************************************************************************************************
included: /srv/corpusops/corpusops.bootstrap/venv/src/ansible/test/integration/targets/include_role_nested/nested/nested/nested/test_nested_dep_role2a/tasks/./rune.yml for testhost

TASK [nested/nested/test_nested_dep_role2a : command] *************************************************************************************************************************************************************************************************************************
changed: [testhost] => {"changed": true, "cmd": "echo from deprole2", "delta": "0:00:00.098868", "end": "2018-01-19 21:28:28.972384", "rc": 0, "start": "2018-01-19 21:28:28.873516", "stderr": "", "stderr_lines": [], "stdout": "from deprole2", "stdout_lines": ["from deprole2"]}

TASK [nested/nested/test_nested_dep_role2 : include_tasks] ********************************************************************************************************************************************************************************************************************
included: /srv/corpusops/corpusops.bootstrap/venv/src/ansible/test/integration/targets/include_role_nested/nested/nested/nested/test_nested_dep_role2/tasks/./rund.yml for testhost

TASK [nested/nested/test_nested_dep_role2 : command] **************************************************************************************************************************************************************************************************************************
changed: [testhost] => {"changed": true, "cmd": "echo from deprole2a", "delta": "0:00:00.110779", "end": "2018-01-19 21:28:29.281009", "rc": 0, "start": "2018-01-19 21:28:29.170230", "stderr": "", "stderr_lines": [], "stdout": "from deprole2a", "stdout_lines": ["from deprole2a"]}

TASK [test_nested_include_task : include_tasks] *******************************************************************************************************************************************************************************************************************************
included: /srv/corpusops/corpusops.bootstrap/venv/src/ansible/test/integration/targets/include_role_nested/roles/test_nested_include_task/tasks/./runa.yml for testhost

TASK [test_nested_include_task : debug] ***************************************************************************************************************************************************************************************************************************************
ok: [testhost] => {
    "msg": "from test_nested_include_task"
}

PLAY RECAP ********************************************************************************************************************************************************************************************************************************************************************
testhost                   : ok=13   changed=3    unreachable=0    failed=0

ACTUAL RESULTS

included tasks doesnt find file

Running include_role_nested integration test script
Run command: ./runme.sh -v
+ ansible-playbook -i../../inventory nested.yml -v
Using /srv/corpusops/corpusops.bootstrap/venv/src/ansible/test/integration/integration.cfg as config file

PLAY [verify that multiple level of nested statements and  include+meta doesnt mess included files mecanisms] *****************************************************************************************************************************************************************

TASK [Gathering Facts] ********************************************************************************************************************************************************************************************************************************************************
ok: [testhost]

TASK [include_tasks] **********************************************************************************************************************************************************************************************************************************************************
included: /srv/corpusops/corpusops.bootstrap/venv/src/ansible/test/integration/targets/include_role_nested/tasks/nested/nested.yml for testhost

TASK [include_tasks] **********************************************************************************************************************************************************************************************************************************************************
included: /srv/corpusops/corpusops.bootstrap/venv/src/ansible/test/integration/targets/include_role_nested/./tasks/nested/../../nestedtasks/nested/nested.yml for testhost

TASK [include_role] ***********************************************************************************************************************************************************************************************************************************************************

TASK [nested/test_nested_dep_role : include_tasks] ****************************************************************************************************************************************************************************************************************************
fatal: [testhost]: FAILED! => {"reason": "Unable to retrieve file contents\nCould not find or access '/srv/corpusops/corpusops.bootstrap/venv/src/ansible/test/integration/targets/include_role_nested/runc.yml'"}
 [WARNING]: Failure using method (v2_runner_on_failed) in callback plugin (<ansible.plugins.callback.junit.CallbackModule object at 0x7f9e22175e10>):
/srv/corpusops/corpusops.bootstrap/venv/src/ansible/test/integration/targets/include_role_nested/nested/nested/test_nested_dep_role/tasks/main.yml:2: verify that multiple level of nested statements and  include+meta doesnt mess included files mecanisms:
nested/test_nested_dep_role : include_tasks _raw_params=./runc.yml: duplicate host callback: testhost

        to retry, use: --limit @/srv/corpusops/corpusops.bootstrap/venv/src/ansible/test/integration/targets/include_role_nested/nested.retry

PLAY RECAP ********************************************************************************************************************************************************************************************************************************************************************
testhost                   : ok=3    changed=0    unreachable=0    failed=1

NOTICE: To resume at this test target, use the option: --start-at include_role_nested
ERROR: Command "./runme.sh -v" returned exit status 2.

This is another solution for #34782 (related to #34783)

related PRs: fix Include role: exposed/shared vars #35167 Include roles with tags in meta/main.yml make a role run more than neccesary #35166 FIX: multiple nested tasks include levels #35165 Include role honour allow duplicates #35164 Include role: serialization: (de)pickling support #35163

maxamillion · 2018-01-23T15:51:44Z

cc @jimi-c @bcoca

kiorky · 2018-01-30T22:37:59Z

!ready_for_review

Related to ansible/ansible:ansible#21890

This fixes the path of included files when you want to call include_task inside a role's task file and this role is itself called from multiple level of playbook include_tasks Related to ansible/ansible:ansible#21890 This fixes ansible/ansible:ansible#35109

* Test for include_tasks & include_role bug Related to ansible/ansible:ansible#21890 * Fix nested include_tasks called from role This fixes the path of included files when you want to call include_task inside a role's task file and this role is itself called from multiple level of playbook include_tasks Related to ansible/ansible:ansible#21890 This fixes ansible/ansible:ansible#35109

jstoja · 2018-02-21T14:00:17Z

@jimi-c Any chances that this fix is included in 2.4 ?
There is like 5 issues on this subject for the 2.4 and 2.5 is still not released.

maxamillion removed the needs_triage Needs a first human triage before being processed. label Jan 23, 2018

kiorky force-pushed the nested_tasks_devel branch 2 times, most recently from d8a41e7 to dfd00c5 Compare January 25, 2018 14:14

ansibot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Jan 25, 2018

kiorky force-pushed the nested_tasks_devel branch from dfd00c5 to c814b43 Compare January 25, 2018 22:36

ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Jan 26, 2018

kiorky force-pushed the nested_tasks_devel branch from c814b43 to 0614986 Compare January 30, 2018 13:09

kiorky force-pushed the nested_tasks_devel branch from 0614986 to 1410e63 Compare January 31, 2018 10:46

This was referenced Jan 31, 2018

fix Include role: exposed/shared vars #35167

Closed

Include roles with tags in meta/main.yml make a role run more than neccesary #35166

Closed

Include role: serialization: (de)pickling support #35163

Closed

kiorky added 2 commits January 31, 2018 12:07

Test for include_tasks & include_role bug

567ee39

Related to ansible/ansible:ansible#21890

kiorky force-pushed the nested_tasks_devel branch from 1410e63 to e2c6218 Compare January 31, 2018 11:08

jimi-c merged commit 9001a87 into ansible:devel Jan 31, 2018

jimi-c mentioned this pull request Jan 31, 2018

fix dynamic include search path. Fixes #34782 #34783

Closed

kiorky deleted the nested_tasks_devel branch January 31, 2018 14:26

kiorky restored the nested_tasks_devel branch February 8, 2018 16:42

ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018

This was referenced Apr 17, 2018

include_tasks in role looks for tasks relative to included task, not role root #33784

Closed

Multiple levels of include_tasks lead to unexpected behavior #35109

Closed

kiorky deleted the nested_tasks_devel branch February 21, 2019 22:45

ansible locked and limited conversation to collaborators Apr 26, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

FIX: multiple nested tasks include levels #35165

FIX: multiple nested tasks include levels #35165

kiorky commented Jan 22, 2018 •

edited

maxamillion commented Jan 23, 2018

kiorky commented Jan 30, 2018

jstoja commented Feb 21, 2018

FIX: multiple nested tasks include levels #35165

FIX: multiple nested tasks include levels #35165

Conversation

kiorky commented Jan 22, 2018 • edited

ISSUE TYPE

COMPONENT NAME

ANSIBLE VERSION

CONFIGURATION

OS / ENVIRONMENT

SUMMARY

STEPS TO REPRODUCE

EXPECTED RESULTS

ACTUAL RESULTS

maxamillion commented Jan 23, 2018

kiorky commented Jan 30, 2018

jstoja commented Feb 21, 2018

kiorky commented Jan 22, 2018 •

edited