fix dynamic include search path. Fixes #34782

[torgiren]

SUMMARY

Fix search paths for include_tasks, when include_role is used

Fixes #34782
It Adds original role tasks folder to search path when using include_tasks.
Adds base (first role which call include_role) tasks as well.

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

dynamic_include strategy (I think)

ANSIBLE VERSION

ansible 2.5.0 (fix_dynamic_include_path e6b2a416bb) last updated 2018/01/12 08:32:10 (GMT +200)
  config file = None
  configured module search path = [u'/home/torgiren/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /tmp/ansible/lib/ansible
  executable location = /tmp/ansible/bin/ansible
  python version = 2.7.14 (default, Nov 26 2017, 14:35:36) [GCC 5.4.0]

2.4.0 as well

ADDITIONAL INFORMATION

full information is in issue

[mkrizek]

cc @bcoca @jimi-c

[mattclay]

CI failure in unit tests:

>                                   cumulative_path = os.path.join(parent_include._role._role_path, "tasks")
E                                   AttributeError: 'NoneType' object has no attribute '_role_path'

lib/ansible/playbook/included_file.py:121: AttributeError

[jimi-c]

Hi @torgiren, could you rebase this, as I've merged #35165 (which touched several of the same lines). There is also another from @pilou- that may require a rebase if it's merged before this as well.

[jimi-c]

Or, if the above PR fixes your original issue as well, please go ahead and close this PR.

[torgiren]

@jimi-c: looks like it's already fixed
I will try it on our production when new version of ansible will be on pypi ;)
thanks