New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure network_cli, nxapi nxos tests run only once - remove unnecessary files #37462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
ansibot
added
bug
This issue/PR relates to a bug.
needs_triage
Needs a first human triage before being processed.
networking
Network category
nxos
Cisco NXOS community
support:network
This issue/PR relates to code supported by the Ansible Network Team.
test
This PR relates to tests.
labels
Mar 15, 2018
trishnaguha
changed the title
Ensure network_cli nxos test is run only once - remove unnecessary files
Ensure network_cli, nxapi nxos tests run only once - remove unnecessary files
Mar 15, 2018
trishnaguha
removed
the
needs_triage
Needs a first human triage before being processed.
label
Mar 15, 2018
ganeshrn
approved these changes
Mar 15, 2018
cherry-picked to 2.5 |
trishnaguha
moved this from Need CP into 2.5.1
to Done
in zzz NOT USED: Networking Bugs
Mar 29, 2018
trishnaguha
added a commit
to trishnaguha/ansible
that referenced
this pull request
Mar 29, 2018
…les (ansible#37462) Signed-off-by: Trishna Guha <trishnaguha17@gmail.com> (cherry picked from commit 957ab02)
trishnaguha
added a commit
that referenced
this pull request
Mar 29, 2018
* Fix nxos_switchport (#37328) (cherry picked from commit ff57fd0) * Fix nxos_l2_interface and test typo (#37336) Signed-off-by: Trishna Guha <trishnaguha17@gmail.com> (cherry picked from commit ba5e562) * fix ios_l2_interface (#37389) Signed-off-by: Trishna Guha <trishnaguha17@gmail.com> (cherry picked from commit dd37857) * fix required args for nxos_snapshot and docs improvement (#37232) Signed-off-by: Trishna Guha <trishnaguha17@gmail.com> (cherry picked from commit a10df8b) * add nxos_snapshot test for missing required param (#37248) Signed-off-by: Trishna Guha <trishnaguha17@gmail.com> (cherry picked from commit 2501834) * Ensure network_cli nxos test is run only once - remove unnecessary files (#37462) Signed-off-by: Trishna Guha <trishnaguha17@gmail.com> (cherry picked from commit 957ab02) * Integration Tests only: nxos_user (#37852) * add new integration file to nxos_user * fix shippable error * change nxapi to connection * review comments (cherry picked from commit 63da50e) * fix UnboundLocalError nxos_bgp_af module (#37610) Signed-off-by: Trishna Guha <trishnaguha17@gmail.com> (cherry picked from commit 00abe6d) * Fix nxos_vrf issues (#37092) * fix nxos_vrf issues * fix doc (cherry picked from commit dc61f4c) * fix nxos_vrf_af issues (#37211) (cherry picked from commit 74e79d9) * fix nxos_udld issues (#37418) (cherry picked from commit 05b266c) * fix nxos_vlan issues (#38008) (cherry picked from commit 6f2cb28) * add changelog Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
bug
This issue/PR relates to a bug.
cisco
Cisco technologies
networking
Network category
nxos
Cisco NXOS community
support:network
This issue/PR relates to code supported by the Ansible Network Team.
test
This PR relates to tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Trishna Guha trishnaguha17@gmail.com
SUMMARY
Ensure network_cli, nxapi nxos tests run only once - remove unnecessary files - cli,nxapi tests are in common dir.
FIX: some of the network_cli, nxapi nxos tests run twice.
ISSUE TYPE
COMPONENT NAME
test/integration/targets/nxos_*/tests/{cli,nxapi}/
ANSIBLE VERSION