Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nxos_switchport #37328

Merged
merged 1 commit into from Mar 13, 2018
Merged

Fix nxos_switchport #37328

merged 1 commit into from Mar 13, 2018

Conversation

mikewiebe
Copy link
Contributor

SUMMARY

Fixes nxos_switchport so that full and partial trunk vlan ranges can be removed.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

nxos_switchport

ANSIBLE VERSION
ansible 2.6.0 (rel250/fix_nxos_switchport 3c03ac0afa) last updated 2018/03/12 22:11:50 (GMT -400)
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/usr/share/ansible']
  ansible python module location = /root/agents-ci/ansible/lib/ansible
  executable location = /root/agents-ci/ansible/bin/ansible
  python version = 2.7.6 (default, Oct 26 2016, 20:30:19) [GCC 4.8.4]
ADDITIONAL INFORMATION

Tested against various NXOS platforms/versions and they all pass.

@ansibot
Copy link
Contributor

ansibot commented Mar 13, 2018

cc @jedelman8 @kedarX @privateip @rahushen @rcarrillocruz @trishnaguha
click here for bot help

@ansibot ansibot added bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. deprecated This issue/PR relates to a deprecated module. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category nxos Cisco NXOS community support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests. labels Mar 13, 2018
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Mar 13, 2018
@ansibot ansibot added the support:community This issue/PR relates to code supported by the Ansible community. label Mar 13, 2018
@trishnaguha trishnaguha added this to the 2.5.0 milestone Mar 13, 2018
@trishnaguha trishnaguha self-assigned this Mar 13, 2018
@trishnaguha trishnaguha merged commit ff57fd0 into ansible:devel Mar 13, 2018
@trishnaguha trishnaguha mentioned this pull request Mar 13, 2018
Merged
@trishnaguha trishnaguha added this to Need CP into 2.5.1 in zzz NOT USED: Networking Bugs Mar 13, 2018
@trishnaguha trishnaguha added this to Nice to have in 2.4.x Blocker List Mar 13, 2018
@trishnaguha
Copy link
Member

cherry-picked to 2.5

@trishnaguha trishnaguha moved this from Need CP into 2.5.1 to Done in zzz NOT USED: Networking Bugs Mar 29, 2018
trishnaguha pushed a commit to trishnaguha/ansible that referenced this pull request Mar 29, 2018
@mikewiebe @trishnaguha
Fix nxos_switchport (ansible#37328)
59370ad 
(cherry picked from commit ff57fd0)
trishnaguha added a commit that referenced this pull request Mar 29, 2018
@trishnaguha
nxos bugfixes cherry-pick (#38091)
a716fe9 
* Fix nxos_switchport (#37328)

(cherry picked from commit ff57fd0)

* Fix nxos_l2_interface and test typo (#37336)

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit ba5e562)

* fix ios_l2_interface (#37389)

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit dd37857)

* fix required args for nxos_snapshot and docs improvement (#37232)

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit a10df8b)

* add nxos_snapshot test for missing required param (#37248)

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit 2501834)

* Ensure network_cli nxos test is run only once - remove unnecessary files (#37462)

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit 957ab02)

* Integration Tests only: nxos_user (#37852)

* add new integration file to nxos_user

* fix shippable error

* change nxapi to connection

* review comments

(cherry picked from commit 63da50e)

* fix UnboundLocalError nxos_bgp_af module (#37610)

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit 00abe6d)

* Fix nxos_vrf issues (#37092)

* fix nxos_vrf issues

* fix doc

(cherry picked from commit dc61f4c)

* fix nxos_vrf_af issues (#37211)

(cherry picked from commit 74e79d9)

* fix nxos_udld issues (#37418)

(cherry picked from commit 05b266c)

* fix nxos_vlan issues (#38008)

(cherry picked from commit 6f2cb28)

* add changelog

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
@mikewiebe mikewiebe deleted the rel250/fix_nxos_switchport branch November 26, 2018 18:06
@dagwieers dagwieers added the cisco Cisco technologies label Feb 23, 2019
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@trishnaguha trishnaguha trishnaguha approved these changes

Assignees

@trishnaguha trishnaguha

Labels
bug This issue/PR relates to a bug. cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. deprecated This issue/PR relates to a deprecated module. module This issue/PR relates to a module. networking Network category nxos Cisco NXOS community support:community This issue/PR relates to code supported by the Ansible community. support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests.
Projects
No open projects
2.4.x Blocker List
Nice to have
zzz NOT USED: Networking Bugs
  
Done
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mikewiebe @ansibot @trishnaguha @dagwieers @bcoca