Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix nxos_vlan issues #38008

Merged
merged 1 commit into from Mar 29, 2018
Merged

fix nxos_vlan issues #38008

merged 1 commit into from Mar 29, 2018

Conversation

saichint
Copy link
Contributor

@saichint saichint commented Mar 27, 2018 •
edited

SUMMARY

Fixes #38007

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

nxos_vlan

ANSIBLE VERSION
ansible 2.6.0 (devel fed20b825f) last updated 2018/02/15 12:51:12 (GMT -400)
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/root/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /root/agents-ci/ansible/lib/ansible
  executable location = /root/agents-ci/ansible/bin/ansible
  python version = 2.7.6 (default, Oct 26 2016, 20:30:19) [GCC 4.8.4]
ADDITIONAL INFORMATION
  • This PR fixes nxos_vlan issues #38007
  • Documentation corrections made.
  • Integration tests enhanced to include all parameters and platform differences
  • Tested on all platforms and they pass

@ansibot
Copy link
Contributor

ansibot commented Mar 27, 2018

cc @jedelman8 @mikewiebe @privateip @rahushen @rcarrillocruz @trishnaguha
click here for bot help

@ansibot ansibot added bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category nxos Cisco NXOS community support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests. labels Mar 27, 2018
@trishnaguha trishnaguha self-assigned this Mar 28, 2018
@trishnaguha trishnaguha removed the needs_triage Needs a first human triage before being processed. label Mar 28, 2018
@trishnaguha trishnaguha added this to the 2.5.0 milestone Mar 28, 2018
@trishnaguha trishnaguha added this to Need CP into 2.5.1 in zzz NOT USED: Networking Bugs Mar 29, 2018
@trishnaguha
Copy link
Member

Thanks for the fix @saichint

@trishnaguha trishnaguha merged commit 6f2cb28 into ansible:devel Mar 29, 2018
@trishnaguha trishnaguha moved this from Need CP into 2.5.1 to Done in zzz NOT USED: Networking Bugs Mar 29, 2018
@trishnaguha
Copy link
Member

cherry-picked to 2.5

trishnaguha pushed a commit to trishnaguha/ansible that referenced this pull request Mar 29, 2018
@trishnaguha
fix nxos_vlan issues (ansible#38008)
2d2a217 
(cherry picked from commit 6f2cb28)
trishnaguha added a commit that referenced this pull request Mar 29, 2018
@trishnaguha
nxos bugfixes cherry-pick (#38091)
a716fe9 
* Fix nxos_switchport (#37328)

(cherry picked from commit ff57fd0)

* Fix nxos_l2_interface and test typo (#37336)

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit ba5e562)

* fix ios_l2_interface (#37389)

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit dd37857)

* fix required args for nxos_snapshot and docs improvement (#37232)

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit a10df8b)

* add nxos_snapshot test for missing required param (#37248)

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit 2501834)

* Ensure network_cli nxos test is run only once - remove unnecessary files (#37462)

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit 957ab02)

* Integration Tests only: nxos_user (#37852)

* add new integration file to nxos_user

* fix shippable error

* change nxapi to connection

* review comments

(cherry picked from commit 63da50e)

* fix UnboundLocalError nxos_bgp_af module (#37610)

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit 00abe6d)

* Fix nxos_vrf issues (#37092)

* fix nxos_vrf issues

* fix doc

(cherry picked from commit dc61f4c)

* fix nxos_vrf_af issues (#37211)

(cherry picked from commit 74e79d9)

* fix nxos_udld issues (#37418)

(cherry picked from commit 05b266c)

* fix nxos_vlan issues (#38008)

(cherry picked from commit 6f2cb28)

* add changelog

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
@saichint saichint deleted the vlan branch March 29, 2018 15:47
ryancurrah pushed a commit to ryancurrah/ansible that referenced this pull request Apr 4, 2018
@ryancurrah
fix nxos_vlan issues (ansible#38008)
38317a6
ilicmilan pushed a commit to ilicmilan/ansible that referenced this pull request Nov 7, 2018
@ilicmilan
fix nxos_vlan issues (ansible#38008)
2524cb0
@dagwieers dagwieers added the cisco Cisco technologies label Feb 23, 2019
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@trishnaguha trishnaguha trishnaguha approved these changes

Assignees

@trishnaguha trishnaguha

Labels
bug This issue/PR relates to a bug. cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. networking Network category nxos Cisco NXOS community support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests.
Projects
No open projects
zzz NOT USED: Networking Bugs
  
Done
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.

nxos_vlan issues
4 participants
@saichint @ansibot @trishnaguha @dagwieers