Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modules to link relatively to docs #39081

Merged
merged 2 commits into from
Apr 20, 2018
Merged

Modules to link relatively to docs #39081

merged 2 commits into from
Apr 20, 2018

Conversation

gundalow
Copy link
Contributor

SUMMARY

L() allows relative links, so if a person is on /devel/ or /2.5/ version of docs they will stay there

ISSUE TYPE
  • Docs Pull Request

@gundalow gundalow requested a review from acozine April 20, 2018 14:35
acozine
acozine approved these changes Apr 20, 2018
View reviewed changes
Copy link
Contributor

@acozine acozine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but please capitalize Guide in "Variable Precedence guide" for consistency.

@ansibot
Copy link
Contributor

ansibot commented Apr 20, 2018

cc @dagwieers
click here for bot help

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Apr 20, 2018
@acozine
Copy link
Contributor

acozine commented Apr 20, 2018

Related to #39030

@gundalow gundalow merged commit 9e028ab into ansible:devel Apr 20, 2018
@gundalow gundalow deleted the relative-module-links-to-docs-site branch April 20, 2018 16:36
gundalow added a commit to gundalow/ansible that referenced this pull request Apr 20, 2018
@gundalow
Modules to link relatively to docs (ansible#39081)
240714b 
* Modules to link relatively to docs

* consistency

(cherry picked from commit 9e028ab)
gundalow added a commit that referenced this pull request Apr 20, 2018
@gundalow
Modules to link relatively to docs (#39081) (#39086)
3e54803 
* Modules to link relatively to docs

* consistency

(cherry picked from commit 9e028ab)
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 14, 2018
@gundalow
Modules to link relatively to docs (ansible#39081)
8b91d2c 
* Modules to link relatively to docs

* consistency
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 15, 2018
@gundalow
Modules to link relatively to docs (ansible#39081)
73429d6 
* Modules to link relatively to docs

* consistency
ilicmilan pushed a commit to ilicmilan/ansible that referenced this pull request Nov 7, 2018
@gundalow @ilicmilan
Modules to link relatively to docs (ansible#39081)
2523de7 
* Modules to link relatively to docs

* consistency
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@acozine acozine acozine approved these changes

Assignees
No one assigned
Labels
core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gundalow @ansibot @acozine