-
Notifications
You must be signed in to change notification settings - Fork 23.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New module postgresql_copy: copy data between a file and a table #56835
Conversation
72ba8b0
to
f33d37d
Compare
012ca67
to
8359f95
Compare
ready_for_review |
@Dorn- @andytom @antoinell @archf @b6d @dschep @jbscalia @jensdepuydt @jscalia @kostiantyn-nemchenko @kustodian @matburt @nerzhul @sebasmannem @tcraxs @wrouesnel As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add |
@Andersson007 nice module and really useful. I have some comments and one or two changes. |
@tcraxs , thank you for the great review! |
@andytom , would be cool if you had a look at this |
Great job, @Andersson007 ... |
I have several objections to the current state of the module. Will try to provide a detailed feedback today. |
@kostiantyn-nemchenko , great! waiting for this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Andersson007 thank you for this PR. I still haven't tested it manually but would be great if you take into account my current suggestions.
@kostiantyn-nemchenko , I envy your ability to concentrate ;) As always the great review ready_for_review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect review and good changes.
LGTM
shipit |
bot_status |
Componentslib/ansible/modules/database/postgresql/postgresql_copy.py lib/ansible/plugins/doc_fragments/postgres.py test/integration/targets/postgresql/tasks/main.yml test/integration/targets/postgresql/tasks/postgresql_copy.yml Metadatawaiting_on: maintainer |
Thanks all! |
SUMMARY
New module postgresql_copy: copy data between a file and a table.
Implements COPY PostgreSQL command.
ISSUE TYPE
SPECIFIC OPTIONS
RETURN
EXAMPLES