Improve dnf test formatting and fix RHEL 8 module name #58648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use single include_vars task rather than multiple set_fact tasks - use multi-line YAML to break up long conditionals - use version() test rather than direct comparisions - use different appstream package on RHEL since '@swig:3.0/default' is not working in the GA
mattclay
approved these changes
Jul 2, 2019
ansibot
added
affects_2.9
mkrizek
approved these changes
Jul 3, 2019
samdoran
added a commit
to samdoran/ansible
that referenced
this pull request
Jul 3, 2019
…nsible#58648) - use single include_vars task rather than multiple set_fact tasks - use multi-line YAML to break up long conditionals - use version() test rather than direct comparisions - use different appstream package on RHEL since '@swig:3.0/default' is not working in the GA (cherry picked from commit 16d6fcf) Co-authored-by: Sam Doran <sdoran@redhat.com>
samdoran
added a commit
to samdoran/ansible
that referenced
this pull request
Jul 3, 2019
…nsible#58648) - use single include_vars task rather than multiple set_fact tasks - use multi-line YAML to break up long conditionals - use version() test rather than direct comparisions - use different appstream package on RHEL since '@swig:3.0/default' is not working in the GA. (cherry picked from commit 16d6fcf) Co-authored-by: Sam Doran <sdoran@redhat.com>
samdoran
added a commit
to samdoran/ansible
that referenced
this pull request
Jul 3, 2019
…nsible#58648) - use single include_vars task rather than multiple set_fact tasks - use multi-line YAML to break up long conditionals - use version() test rather than direct comparisions (cherry picked from commit 16d6fcf)
abadger
pushed a commit
that referenced
this pull request
Jul 16, 2019
…58648) - use single include_vars task rather than multiple set_fact tasks - use multi-line YAML to break up long conditionals - use version() test rather than direct comparisions - use different appstream package on RHEL since '@swig:3.0/default' is not working in the GA (cherry picked from commit 16d6fcf) Co-authored-by: Sam Doran <sdoran@redhat.com>
abadger
pushed a commit
that referenced
this pull request
Jul 17, 2019
…58648) - use single include_vars task rather than multiple set_fact tasks - use multi-line YAML to break up long conditionals - use version() test rather than direct comparisions - use different appstream package on RHEL since '@swig:3.0/default' is not working in the GA. (cherry picked from commit 16d6fcf) Co-authored-by: Sam Doran <sdoran@redhat.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
include_varstask rather than multipleset_facttasksversion()test rather than direct comparisonsI am not sure why, but it seems using
/defaultin the RHEL 8 GA is broken. According to this document,/defaultshould be omitted:Maybe it's just a problem with
swigbut I got similar errors using/defaulton other modules. I believe I found a module that works reliably with RHEL 8 GA.ISSUE TYPE
COMPONENT NAME
test/integration/targets/dnf/