Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fixes for GCP (as of 2019-07-09T06:06:53Z) #59324

Merged
merged 2 commits into from Jul 29, 2019
Merged

Bug fixes for GCP (as of 2019-07-09T06:06:53Z) #59324

merged 2 commits into from Jul 29, 2019

Conversation

modular-magician
Copy link
Contributor

SUMMARY

Bug fixes for GCP (as of 2019-07-09T06:06:53Z)
This PR is the result of the following Magic Modules PRs:

ISSUE TYPE
  • Bugfix Pull Request
ADDITIONAL INFORMATION
This was generated by [Magic Modules](https://github.com/googlecloudplatform/magic-modules)

@ansibot
Copy link
Contributor

ansibot commented Jul 19, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 11 errors:

test/sanity/validate-modules/ignore.txt:715:1: A102 Remove since "lib/ansible/modules/cloud/google/gcp_compute_url_map.py" passes "E337" test
test/sanity/validate-modules/ignore.txt:717:1: A102 Remove since "lib/ansible/modules/cloud/google/gcp_compute_vpn_tunnel.py" passes "E337" test
test/sanity/validate-modules/ignore.txt:718:1: A102 Remove since "lib/ansible/modules/cloud/google/gcp_container_cluster.py" passes "E337" test
test/sanity/validate-modules/ignore.txt:719:1: A102 Remove since "lib/ansible/modules/cloud/google/gcp_container_node_pool.py" passes "E337" test
test/sanity/validate-modules/ignore.txt:721:1: A102 Remove since "lib/ansible/modules/cloud/google/gcp_dns_managed_zone.py" passes "E337" test
test/sanity/validate-modules/ignore.txt:722:1: A102 Remove since "lib/ansible/modules/cloud/google/gcp_dns_resource_record_set.py" passes "E337" test
test/sanity/validate-modules/ignore.txt:732:1: A102 Remove since "lib/ansible/modules/cloud/google/gcp_iam_role.py" passes "E337" test
test/sanity/validate-modules/ignore.txt:733:1: A102 Remove since "lib/ansible/modules/cloud/google/gcp_iam_service_account_key.py" passes "E337" test
test/sanity/validate-modules/ignore.txt:734:1: A102 Remove since "lib/ansible/modules/cloud/google/gcp_iam_service_account.py" passes "E337" test
test/sanity/validate-modules/ignore.txt:735:1: A102 Remove since "lib/ansible/modules/cloud/google/gcp_pubsub_subscription.py" passes "E337" test
test/sanity/validate-modules/ignore.txt:736:1: A102 Remove since "lib/ansible/modules/cloud/google/gcp_pubsub_topic.py" passes "E337" test

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Jul 19, 2019

cc @erjohnso @GoogleCloudPlatform @rambleraptor
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. ci_verified Changes made in this PR are causing tests to fail. cloud gce module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. labels Jul 19, 2019
@ansibot
Copy link
Contributor

ansibot commented Jul 19, 2019

cc @mattclay
click here for bot help

@ansibot ansibot added support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. core_review In order to be merged, this PR must follow the core review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jul 19, 2019
@rambleraptor
Copy link
Contributor

@mattclay please take a look! The Google stuff looks great, but I don't have permission to alter the ignore.txt file.

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Jul 22, 2019
@mattclay mattclay mentioned this pull request Jul 22, 2019
Closed
@jctanner
Copy link
Contributor

bot_status

@ansibot
Copy link
Contributor

ansibot commented Jul 22, 2019

Components

lib/ansible/modules/cloud/google/gcp_compute_url_map.py
support: community
maintainers: erjohnso googlecloudplatform rambleraptor

lib/ansible/modules/cloud/google/gcp_compute_vpn_tunnel.py
support: community
maintainers: erjohnso googlecloudplatform rambleraptor

lib/ansible/modules/cloud/google/gcp_container_cluster.py
support: community
maintainers: erjohnso googlecloudplatform rambleraptor

lib/ansible/modules/cloud/google/gcp_container_node_pool.py
support: community
maintainers: erjohnso googlecloudplatform rambleraptor

lib/ansible/modules/cloud/google/gcp_dns_managed_zone.py
support: community
maintainers: erjohnso googlecloudplatform rambleraptor

lib/ansible/modules/cloud/google/gcp_dns_resource_record_set.py
support: community
maintainers: erjohnso googlecloudplatform rambleraptor

lib/ansible/modules/cloud/google/gcp_iam_role.py
support: community
maintainers: erjohnso googlecloudplatform rambleraptor

lib/ansible/modules/cloud/google/gcp_iam_service_account.py
support: community
maintainers: erjohnso googlecloudplatform rambleraptor

lib/ansible/modules/cloud/google/gcp_iam_service_account_key.py
support: community
maintainers: erjohnso googlecloudplatform rambleraptor

lib/ansible/modules/cloud/google/gcp_pubsub_subscription.py
support: community
maintainers: erjohnso googlecloudplatform rambleraptor

lib/ansible/modules/cloud/google/gcp_pubsub_topic.py
support: community
maintainers: erjohnso googlecloudplatform rambleraptor

test/sanity/validate-modules/ignore.txt
support: core
maintainers:

Metadata

waiting_on: ansible
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
too many files or commits: False
mergeable_state: clean
shippable_status: success
maintainer_shipits (module maintainers): 0
community_shipits (namespace maintainers): 0
ansible_shipits (core team members): 0
shipit_actors (maintainer or core team member): []
shipit_actors_other: []
automerge: automerge shipit test failed

click here for bot help

@rambleraptor
Copy link
Contributor

@jctanner PR is rebased!

@ansibot ansibot added has_issue needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jul 23, 2019
@rambleraptor
Copy link
Contributor

(looks like build failure is an azure issue)

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jul 23, 2019
@rambleraptor
Copy link
Contributor

shipit

@ansibot
Copy link
Contributor

ansibot commented Jul 26, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 11 errors:

test/sanity/ignore.txt:757:1: A100 Ignoring 'E337' on 'lib/ansible/modules/cloud/google/gcp_compute_url_map.py' is unnecessary
test/sanity/ignore.txt:759:1: A100 Ignoring 'E337' on 'lib/ansible/modules/cloud/google/gcp_compute_vpn_tunnel.py' is unnecessary
test/sanity/ignore.txt:761:1: A100 Ignoring 'E337' on 'lib/ansible/modules/cloud/google/gcp_container_cluster.py' is unnecessary
test/sanity/ignore.txt:762:1: A100 Ignoring 'E337' on 'lib/ansible/modules/cloud/google/gcp_container_node_pool.py' is unnecessary
test/sanity/ignore.txt:763:1: A100 Ignoring 'E337' on 'lib/ansible/modules/cloud/google/gcp_dns_managed_zone.py' is unnecessary
test/sanity/ignore.txt:765:1: A100 Ignoring 'E337' on 'lib/ansible/modules/cloud/google/gcp_dns_resource_record_set.py' is unnecessary
test/sanity/ignore.txt:766:1: A100 Ignoring 'E337' on 'lib/ansible/modules/cloud/google/gcp_iam_role.py' is unnecessary
test/sanity/ignore.txt:767:1: A100 Ignoring 'E337' on 'lib/ansible/modules/cloud/google/gcp_iam_service_account.py' is unnecessary
test/sanity/ignore.txt:768:1: A100 Ignoring 'E337' on 'lib/ansible/modules/cloud/google/gcp_iam_service_account_key.py' is unnecessary
test/sanity/ignore.txt:769:1: A100 Ignoring 'E337' on 'lib/ansible/modules/cloud/google/gcp_pubsub_subscription.py' is unnecessary
test/sanity/ignore.txt:770:1: A100 Ignoring 'E337' on 'lib/ansible/modules/cloud/google/gcp_pubsub_topic.py' is unnecessary

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Jul 26, 2019
@ansibot
Copy link
Contributor

ansibot commented Jul 26, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 11 errors:

test/sanity/ignore.txt:757:1: A100 Ignoring 'E337' on 'lib/ansible/modules/cloud/google/gcp_compute_url_map.py' is unnecessary
test/sanity/ignore.txt:759:1: A100 Ignoring 'E337' on 'lib/ansible/modules/cloud/google/gcp_compute_vpn_tunnel.py' is unnecessary
test/sanity/ignore.txt:761:1: A100 Ignoring 'E337' on 'lib/ansible/modules/cloud/google/gcp_container_cluster.py' is unnecessary
test/sanity/ignore.txt:762:1: A100 Ignoring 'E337' on 'lib/ansible/modules/cloud/google/gcp_container_node_pool.py' is unnecessary
test/sanity/ignore.txt:763:1: A100 Ignoring 'E337' on 'lib/ansible/modules/cloud/google/gcp_dns_managed_zone.py' is unnecessary
test/sanity/ignore.txt:765:1: A100 Ignoring 'E337' on 'lib/ansible/modules/cloud/google/gcp_dns_resource_record_set.py' is unnecessary
test/sanity/ignore.txt:766:1: A100 Ignoring 'E337' on 'lib/ansible/modules/cloud/google/gcp_iam_role.py' is unnecessary
test/sanity/ignore.txt:767:1: A100 Ignoring 'E337' on 'lib/ansible/modules/cloud/google/gcp_iam_service_account.py' is unnecessary
test/sanity/ignore.txt:768:1: A100 Ignoring 'E337' on 'lib/ansible/modules/cloud/google/gcp_iam_service_account_key.py' is unnecessary
test/sanity/ignore.txt:769:1: A100 Ignoring 'E337' on 'lib/ansible/modules/cloud/google/gcp_pubsub_subscription.py' is unnecessary
test/sanity/ignore.txt:770:1: A100 Ignoring 'E337' on 'lib/ansible/modules/cloud/google/gcp_pubsub_topic.py' is unnecessary

click here for bot help

@ansibot ansibot added support:core This issue/PR relates to code supported by the Ansible Engineering Team. core_review In order to be merged, this PR must follow the core review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jul 26, 2019
@rambleraptor
Copy link
Contributor

shipit

@rambleraptor
Copy link
Contributor

@mattclay could you merge this in while waiting for the ansibot fix?

@mattclay mattclay merged commit 4a7e11b into ansible:devel Jul 29, 2019
@ansible ansible locked and limited conversation to collaborators Aug 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. cloud core_review In order to be merged, this PR must follow the core review workflow. gce has_issue module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@modular-magician @ansibot @rambleraptor @jctanner @mattclay