postgresql_user: allow to pass user name with dots

[Andersson007]

SUMMARY

postgresql_user: allow to pass user name with dots

fixes: #63204

it is obvious now - pg_quote_identifier doesn't work in this case

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

lib/ansible/module_utils/postgres.py
lib/ansible/modules/database/postgresql/postgresql_user.py

[Andersson007]

@kostiantyn-nemchenko , @andytom , @kustodian , it does need your review

[ansibot]

cc @Dorn- @amenonsen @jbscalia @matburt @nerzhul @sebasmannem @tcraxs
click here for bot help

[Andersson007]

ready_for_review

[Spindel]

I think the code could simply remove those if statements on period, and just always quote identifiers properly?

[Andersson007]

@Spindel which exact identifiers do you mean in case of role?
IMO identifiers were initially added to be able to handle names like “dbname.schemaname.tablename” -> “dbname”.”schemaname”.”tablename”
I’m not absolutely sure but it’s unclear for me which identifiers i can use with role. It is a global object.
Dot is a part of user name in this case, not an indicator of identifiers

[Andersson007]

@andytom , @Spindel , i've just changed all that stuff - set "%s" wherever was possible (in DDL queries). Looks better now, much less changes.. (it was the last, 6th PR probably, for today.. so was a bit exhausted doing that:)
@Spindel , if you meant this, sorry, i didn't understand
@andytom , thanks you for the explanation

[Andersson007]

ready_for_review

[Spindel]

Took a look at the diff, and that change looks a lot better, and no strange branching that can fall out badly. LGTM.

…

On Wed, Oct 16, 2019 at 9:14 PM Andrey Klychkov ***@***.***> wrote: ready_for_review — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#63565?email_source=notifications&email_token=AAMYRZSTYVLFNAOXYO5EDIDQO5R2BA5CNFSM4JBMCLKKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBNTXWA#issuecomment-542850008>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAMYRZSCEALRFABWGYBBQ7DQO5R2BANCNFSM4JBMCLKA> .

[tcraxs]

LGTM

[andytom]

LGTM
shipit

Is this something that should be added to the other modules that deal with roles like postgresql_privs and postgresql_membership?

[Andersson007]

@andytom postgresql_membership uses the same class, its (and others) CI were passed, i checked.
i'll check postgresql_privs later, after #63555 is merged, not to mix all in one pr

[Andersson007]

@andytom @tcraxs thak you for approving