Don't treat parsing problems as async task timeout #16458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
|
Tentative +1 to this. We talked about it in IRC. The drawback of doing this is that parsing errors will no longer fail the task... we'll end up waiting the full timeout period instead. @emonty we should add a comment explaining the condtions that we exit here, though, and your explanation of why we are ignoring parsing errors. (otherwise some later refactoring may remove it accidentally.) |
bcoca
added
the
needs_rebase
|
looks good, but you got submodule ref updates that should not be here |
If there is a problem reading/writing the status file that manifests as not being able to parse the data, that doesn't mean the task timed out, it means there was what was likely a tempoarary problem. Move on and keep polling for success. The only things that should cause the async status to not be parseable are bugs in the async_runner.
| return dict(failed=True, msg="async task did not complete within the requested time") | ||
| else: | ||
| return dict(failed=True, msg="async task produced unparseable results", async_result=async_result) | ||
| else: |
There was a problem hiding this comment.
Spurious else:
Breaking the tests.
abadger
pushed a commit
that referenced
this pull request
Jul 6, 2016
* Don't treat parsing problems as async task timeout If there is a problem reading/writing the status file that manifests as not being able to parse the data, that doesn't mean the task timed out, it means there was what was likely a tempoarary problem. Move on and keep polling for success. The only things that should cause the async status to not be parseable are bugs in the async_runner. * Add comment explaining not bailing out of loop * Return different error when result is unparseable * Remove extraneous else
bcoca
pushed a commit
that referenced
this pull request
Aug 15, 2016
We want to NOT consider the async task as failed if the result is not parsed, which was the intent of: #16458 However, the logic doesn't actually do that because we default the 'parsed' value to True. It should default to False so that we continue waiting, as intended.
bcoca
pushed a commit
that referenced
this pull request
Aug 15, 2016
We want to NOT consider the async task as failed if the result is not parsed, which was the intent of: #16458 However, the logic doesn't actually do that because we default the 'parsed' value to True. It should default to False so that we continue waiting, as intended. (cherry picked from commit bf8c871)
ansibot
added
bug
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE TYPE
ANSIBLE VERSION
SUMMARY
If there is a problem reading/writing the status file that manifests as
not being able to parse the data, that doesn't mean the task timed out,
it means there was what was likely a tempoarary problem. Move on and
keep polling for success. The only things that should cause the async
status to not be parseable are bugs in the async_runner.