Skip to content
Permalink
Browse files

Fix async logic when parsing fails (#17091)

We want to NOT consider the async task as failed if the result is
not parsed, which was the intent of:

  #16458

However, the logic doesn't actually do that because we default
the 'parsed' value to True. It should default to False so that
we continue waiting, as intended.
(cherry picked from commit bf8c871)
  • Loading branch information...
Shrews authored and bcoca committed Aug 15, 2016
1 parent 616a51a commit d35377dac78a8fcc6e8acf0ffd92f47f44d70946
Showing with 1 addition and 1 deletion.
  1. +1 −1 lib/ansible/executor/task_executor.py
@@ -587,7 +587,7 @@ def _poll_async_result(self, result, templar, task_vars=None):
# have issues which result in a half-written/unparseable result
# file on disk, which manifests to the user as a timeout happening
# before it's time to timeout.
if int(async_result.get('finished', 0)) == 1 or ('failed' in async_result and async_result.get('parsed', True)) or 'skipped' in async_result:
if int(async_result.get('finished', 0)) == 1 or ('failed' in async_result and async_result.get('parsed', False)) or 'skipped' in async_result:
break

time_left -= self._task.poll

0 comments on commit d35377d

Please sign in to comment.
You can’t perform that action at this time.