Fix async logic when parsing fails #17091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to NOT consider the async task as failed if the result is not parsed, which was the intent of: #16458 However, the logic doesn't actually do that because we default the 'parsed' value to True. It should default to False so that we continue waiting, as intended.
bcoca
pushed a commit
that referenced
this pull request
Aug 15, 2016
We want to NOT consider the async task as failed if the result is not parsed, which was the intent of: #16458 However, the logic doesn't actually do that because we default the 'parsed' value to True. It should default to False so that we continue waiting, as intended. (cherry picked from commit bf8c871)
ansibot
added
bug
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE TYPE
COMPONENT NAME
lib/ansible/executor/task_executor.py
ANSIBLE VERSION
This affects 2.2.0 and 2.1.1.0
SUMMARY
We want to NOT consider the async task as failed if the result is
not parsed, which was the intent of:
#16458
However, the logic doesn't actually do that because we default
the 'parsed' value to True. It should default to False so that
we continue waiting, as intended.