Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ios_vlan and ios_l2_interface issues CP in 2.5 #44253

Merged
merged 3 commits into from Sep 5, 2018
Merged

Fix ios_vlan and ios_l2_interface issues CP in 2.5 #44253

merged 3 commits into from Sep 5, 2018

Conversation

NilashishC
Copy link
Contributor

@NilashishC
Fixes ios_l2_interface and ios_vlan not working on certain interface …
5fd450c 
…types issue (#43819)

* Fixes #43654 and #43582

* Remove q statement

* Fix shippable errors

* Fix more shippable errors

* Fix unittest

(cherry picked from commit b14f256)
@NilashishC
Added changelog entries
c56ea08
@ansibot
Copy link
Contributor

ansibot commented Aug 16, 2018

cc @Qalthos @ganeshrn @gdpak @Qalthos @rcarrillocruz @trishnaguha
click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Aug 16, 2018

Hi @NilashishC,

Thank you for the pullrequest, just so you are aware we have a dedicated Working Group for network.
You can find other people interested in this in #ansible-network on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category support:core This issue/PR relates to code supported by the Ansible Engineering Team. support:network This issue/PR relates to code supported by the Ansible Network Team. labels Aug 16, 2018
@NilashishC NilashishC added this to To Do in 2.5.x blocker list via automation Aug 16, 2018
@ansibot
Copy link
Contributor

ansibot commented Aug 16, 2018

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

changelogs/fragments/fix_ios_l2_interface.yaml:4:1: empty-lines too many blank lines (1 > 0)

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Aug 16, 2018
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 16, 2018
@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label Aug 16, 2018
@ansibot
Copy link
Contributor

ansibot commented Aug 24, 2018

cc @justjais
click here for bot help

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Aug 24, 2018
@NilashishC NilashishC assigned NilashishC and unassigned NilashishC Aug 29, 2018
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Aug 29, 2018
@nitzmahone nitzmahone merged commit 847a7f9 into ansible:stable-2.5 Sep 5, 2018
@dagwieers dagwieers added the ios Cisco IOS community label Feb 27, 2019
@dagwieers dagwieers added the cisco Cisco technologies label Feb 27, 2019
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.5 This issue/PR affects Ansible v2.5 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. ios Cisco IOS community module This issue/PR relates to a module. networking Network category support:core This issue/PR relates to code supported by the Ansible Engineering Team. support:network This issue/PR relates to code supported by the Ansible Network Team.
Projects
No open projects
2.5.x blocker list
  
To Do
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@NilashishC @ansibot @dagwieers @samdoran @nitzmahone