Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'auto' to documented default enabled inventory plugins #46621

Merged
merged 3 commits into from
Oct 8, 2018
Merged

Add 'auto' to documented default enabled inventory plugins #46621

merged 3 commits into from
Oct 8, 2018

Conversation

s-hertel
Copy link
Contributor

@s-hertel s-hertel commented Oct 8, 2018

SUMMARY

Make the docs and ansible.cfg reflect the default actually being used (https://github.com/ansible/ansible/blob/devel/lib/ansible/config/base.yml#L1422).

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

docs/docsite/rst/plugins/inventory.rst
examples/ansible.cfg

ANSIBLE VERSION
ansible 2.8.0.dev0

@ansibot
Copy link
Contributor

ansibot commented Oct 8, 2018

@s-hertel: thank you for submitting this pull-request !

cc @acozine
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 docs This issue/PR relates to or includes documentation. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Oct 8, 2018
@s-hertel s-hertel removed the needs_triage Needs a first human triage before being processed. label Oct 8, 2018
acozine
acozine reviewed Oct 8, 2018
View reviewed changes
docs/docsite/rst/plugins/inventory.rst
@@ -11,7 +11,7 @@ Inventory plugins allow users to point at data sources to compile the inventory
.. _enabling_inventory:

Enabling Inventory Plugins
++++++++++++++++++++++++++
--------------------------
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the headers @s-hertel - could you also fix the top header (line 5)? It should be underlined with =======. See #35520. Thanks!

@acozine acozine merged commit 43d12c1 into ansible:devel Oct 8, 2018
s-hertel added a commit to s-hertel/ansible that referenced this pull request Oct 8, 2018
@s-hertel
Add 'auto' to documented default enabled inventory plugins (ansible#4…
2665f83 
…6621)

* Correct default inventory plugins enabled in docs and example/ansible.cfg

* Fix headers

(cherry picked from commit 43d12c1)
s-hertel added a commit to s-hertel/ansible that referenced this pull request Oct 8, 2018
@s-hertel
Add 'auto' to documented default enabled inventory plugins (ansible#4…
c76ab9b 
…6621)

* Correct default inventory plugins enabled in docs and example/ansible.cfg

* Fix headers

(cherry picked from commit 43d12c1)
s-hertel added a commit to s-hertel/ansible that referenced this pull request Oct 8, 2018
@s-hertel
Add 'auto' to documented default enabled inventory plugins (ansible#4…
83c9daf 
…6621)

* Correct default inventory plugins enabled in docs and example/ansible.cfg

* Fix headers

(cherry picked from commit 43d12c1)
This was referenced Oct 8, 2018
Merged
Merged
Merged
acozine pushed a commit that referenced this pull request Oct 8, 2018
@s-hertel @acozine
Add 'auto' to documented default enabled inventory plugins (#46621) (#…
62b43ea 
…46637)

* Correct default inventory plugins enabled in docs and example/ansible.cfg

* Fix headers

(cherry picked from commit 43d12c1)
acozine pushed a commit that referenced this pull request Oct 8, 2018
@s-hertel @acozine
Add 'auto' to documented default enabled inventory plugins (#46621) (#…
0172576 
…46638)

* Correct default inventory plugins enabled in docs and example/ansible.cfg

* Fix headers

(cherry picked from commit 43d12c1)
acozine pushed a commit that referenced this pull request Oct 8, 2018
@s-hertel @acozine
Add 'auto' to documented default enabled inventory plugins (#46621) (#…
9a497b0 
…46639)

* Correct default inventory plugins enabled in docs and example/ansible.cfg

* Fix headers

(cherry picked from commit 43d12c1)
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@acozine acozine acozine left review comments

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 docs This issue/PR relates to or includes documentation. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@s-hertel @ansibot @acozine