Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fortinet FortiManager Firewall Policy Packages and Groups Module #46715

Closed
wants to merge 6 commits into from
Closed

Fortinet FortiManager Firewall Policy Packages and Groups Module #46715

wants to merge 6 commits into from

Conversation

ftntcorecse
Copy link
Contributor

SUMMARY

Allows the add/edit/delete of FortiManager Firewall Policy Packages, and the Folders that organize them.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

fmgr_fwpol_package.py
test_fmgr_fwpol_package.py
fixtures/test_fmgr_fwpol_package.py

ANSIBLE VERSION
ansible 2.8.0.dev0 (devel 9efc3dc761) last updated 2018/09/27 20:21:00 (GMT -700)
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/usr/ansible_ftnt/library']
  ansible python module location = /root/ansibleSource/ansible/lib/ansible
  executable location = /root/ansibleSource/ansible/bin/ansible
  python version = 2.6.9 (unknown, Sep 27 2018, 21:07:46) [GCC 5.4.0 20160609]
ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Oct 9, 2018

@ftntcorecse: thank you for submitting this pull-request!

cc @NilashishC @Qalthos @ganeshrn @gdpak @justjais @rcarrillocruz @trishnaguha
click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Oct 9, 2018

Hi @ftntcorecse,

Thank you for the pullrequest, just so you are aware we have a dedicated Working Group for network.
You can find other people interested in this in #ansible-network on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category new_contributor This PR is the first contribution by a new community member. new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Oct 9, 2018
@jborean93 jborean93 removed the needs_triage Needs a first human triage before being processed. label Oct 11, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Oct 25, 2018
@gdpak gdpak self-assigned this Nov 2, 2018
@ansibot
Copy link
Contributor

ansibot commented Nov 14, 2018

cc @ftntcorecse @Ghilli3 @lweighall @p4r4n0y1ng
click here for bot help

@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Nov 14, 2018
@ansibot ansibot removed the new_contributor This PR is the first contribution by a new community member. label Nov 21, 2018
@ftntcorecse
Copy link
Contributor Author

Ready to ship

@gdpak gdpak mentioned this pull request Nov 30, 2018
Closed
@ansibot ansibot removed the core_review In order to be merged, this PR must follow the core review workflow. label Nov 30, 2018
@ansibot ansibot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Nov 30, 2018
@ftntcorecse
Copy link
Contributor Author

@gdpak -- I would like to chat tonight if possible. I'm on Pacific Standard Time, and work late. I'm on skype as "lukeweighall". I have a Go To Meeting Account we can use. Please let me know if this is a possibility

-Luke

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Dec 12, 2018
This was referenced Jan 15, 2019
Closed
Closed
Closed
@ftntcorecse ftntcorecse deleted the fmgr_fwpol_package branch February 21, 2019 04:24
@dagwieers dagwieers added the fortimanager Fortimanager community label Feb 22, 2019
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gdpak gdpak gdpak requested changes

Assignees

@gdpak gdpak

Labels
affects_2.8 This issue/PR affects Ansible v2.8 fortimanager Fortimanager community module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. networking Network category new_module This PR includes a new module. new_plugin This PR includes a new plugin. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ftntcorecse @ansibot @gdpak @dagwieers @jborean93 @lweighall