Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ecs service force new deployment #47983

Merged
merged 7 commits into from
Nov 24, 2018
Merged

Ecs service force new deployment #47983

merged 7 commits into from
Nov 24, 2018

Conversation

ezmac
Copy link
Contributor

@ezmac ezmac commented Nov 2, 2018

SUMMARY

Adds force_new_deployment parameter to ecs_service module.

I picked up the work from via mentioned in #42518, added botocore version checks, and excluded the param from update service if not set so it will work with older versions of botocore.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

ecs_service

ANSIBLE VERSION
ansible 2.8.0.dev0 (ecs_service_force_new_deployment 5dcbcddb21) last updated 2018/11/02 10:06:03 (GMT -400)
  config file = None
  configured module search path = ['/home/tad/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /home/tad/code/ansible/lib/ansible
  executable location = /home/tad/code/ansible/bin/ansible
  python version = 3.5.2 (default, Nov 23 2017, 16:37:01) [GCC 5.4.0 20160609]

@ansibot
Copy link
Contributor

ansibot commented Nov 2, 2018

Hi @ezmac, thank you for submitting this pull-request!

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Nov 2, 2018

cc @Java1Guy @Java1Guy @kaczynskid @willthames @zacblazic
click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Nov 2, 2018

@ezmac, just so you are aware we have a dedicated Working Group for aws.
You can find other people interested in this in #ansible-aws on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 aws cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. labels Nov 2, 2018
@s-hertel s-hertel removed the needs_triage Needs a first human triage before being processed. label Nov 2, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Nov 10, 2018
@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Nov 23, 2018
@ezmac ezmac force-pushed the ecs_service_force_new_deployment branch from b50f3c8 to 0278c80 Compare November 23, 2018 20:05
@ansibot ansibot removed the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Nov 23, 2018
@ezmac
Copy link
Contributor Author

ezmac commented Nov 23, 2018

ready_for_review

@ansibot ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Nov 23, 2018
@ansibot ansibot added the community_review In order to be merged, this PR must follow the community review workflow. label Nov 23, 2018
@willthames willthames merged commit 4b2356f into ansible:devel Nov 24, 2018
@willthames
Copy link
Contributor

Merged for inclusion in 2.8, thanks @ezmac

mjmayer pushed a commit to mjmayer/ansible that referenced this pull request Nov 30, 2018
@ezmac @mjmayer
Ecs service force new deployment (ansible#47983)
7ffd142 
* Support UpdateService forceNewDeployment in ecs_service module

* Force update to be called if force_new_deployment set

* Fixes for review

* Add force_new_deployment option to ecs_service.py

cherrypicks changes from via/ansible
Adds tests for pull request ansible#42518
fixes backwards compatability with boto<1.8.4

* change version_added to 2.8 for force_new_deployment

* remove extra lines from test

* remove more unnecessary whitespace
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gundalow gundalow gundalow left review comments

@s-hertel s-hertel s-hertel approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 aws cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. new_contributor This PR is the first contribution by a new community member. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ezmac @ansibot @willthames @gundalow @s-hertel