Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS: make jittered_backoff API parameter configurable #49086

Merged
merged 3 commits into from
Dec 16, 2018
Merged

AWS: make jittered_backoff API parameter configurable #49086

merged 3 commits into from
Dec 16, 2018

Conversation

Akasurde
Copy link
Member

SUMMARY

Signed-off-by: Abhijeet Kasurde akasurde@redhat.com

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

lib/ansible/modules/cloud/amazon/cloudformation.py

This was referenced Nov 24, 2018
Closed
Closed
@ansibot
Copy link
Contributor

ansibot commented Nov 24, 2018

Hi @Akasurde, thank you for submitting this pull-request!

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Nov 24, 2018

cc @jsmartin @ryansb @tedder
click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Nov 24, 2018

@Akasurde, just so you are aware we have a dedicated Working Group for aws.
You can find other people interested in this in #ansible-aws on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 aws cloud core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Nov 24, 2018
@tedder
Copy link
Contributor

tedder commented Nov 24, 2018

I'd prefer the parameters to be prefixed to keep them logically (and lexicographically) together, since they are sort of "meta" parameters, not part of AWS's API itself. Perhaps "backoff_retries", "backoff_delay", etc.

That's just my opinion though, wondering what you think about that.

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Nov 24, 2018
@Akasurde
Copy link
Member Author

I am also OK with appending backoff_ as in front of every parameter. I am also open to suggestions.

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Dec 4, 2018
@s-hertel
Copy link
Contributor

s-hertel commented Dec 4, 2018

I like the backoff_ prefix. I also think the options should be consistent when implemented in new modules, so documenting the choice in https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/cloud/amazon/GUIDELINES.md#api-throttling-and-pagination would be good.

@willthames Do you have thoughts on this?

@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Dec 5, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Dec 13, 2018
@Akasurde
Copy link
Member Author

@tedder @s-hertel Could you please take another look into this ? Thanks.

@Akasurde
AWS: make jittered_backoff API parameter configurable
0e136d2 
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@Akasurde
Review comments
a342ffd 
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@Akasurde
minor doc changes
93063b0 
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Dec 16, 2018
@tedder
Copy link
Contributor

tedder commented Dec 16, 2018

Hooray, shipit.

@Akasurde Akasurde merged commit 1558f77 into ansible:devel Dec 16, 2018
@Akasurde Akasurde deleted the i22479 branch December 16, 2018 05:38
kbreit pushed a commit to kbreit/ansible that referenced this pull request Jan 11, 2019
@Akasurde @kbreit
AWS: make jittered_backoff API parameter configurable (ansible#49086)
fd9c13c 
* AWS: make jittered_backoff API parameter configurable
* Review comments
* minor doc changes

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tedder tedder tedder left review comments

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 aws cloud core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Akasurde @ansibot @tedder @s-hertel