Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pydoc example #52605

Closed
wants to merge 1 commit into from
Closed

fix pydoc example #52605

wants to merge 1 commit into from

Conversation

darkhipo
Copy link

The example, as given does not work.
It creates some association, but that association does not work as intended.
The change here ensures that it does work as intended, that is, triggering lambda function executions upon object creation in the specified s3 bucket.

+label: docsite_pr

SUMMARY
ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
  • Feature Pull Request
  • New Module Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

The example, as given does not work.
It creates some association, but that association does not work as intended.
The change here ensures that it does work as intended, that is, triggering lambda function executions upon object creation in the specified s3 bucket. 

+label: docsite_pr
@ansibot
Copy link
Contributor

ansibot commented Feb 19, 2019

cc @mikedlr @pjodouin
click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Feb 19, 2019

@darkhipo, just so you are aware we have a dedicated Working Group for aws.
You can find other people interested in this in #ansible-aws on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 aws bug This issue/PR relates to a bug. cloud module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. small_patch support:community This issue/PR relates to code supported by the Ansible community. labels Feb 19, 2019
@dagwieers dagwieers added the docsite_pr This PR is created from documentation using the "Edit on GitHub" link. label Feb 22, 2019
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. labels Feb 22, 2019
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Mar 2, 2019
@acozine acozine added the docs This issue/PR relates to or includes documentation. label May 21, 2019
@@ -110,7 +110,8 @@
statement_id: lambda-s3-myBucket-create-data-log
action: lambda:InvokeFunction
principal: s3.amazonaws.com
source_arn: arn:aws:s3:eu-central-1:123456789012:bucketName
source_arn: arn:aws:s3:::bucketName
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have tests that run in CI that specify a complete ARN:

- name: give api gateway execute permissions on lambda
lambda_policy:
function_name: "{{ lambda_function_name }}"
state: present
statement_id: api-gateway-invoke-lambdas
action: lambda:InvokeFunction
principal: apigateway.amazonaws.com
source_arn: "arn:aws:execute-api:{{ aws_region }}:{{ aws_caller_facts.account }}:*/*"
<<: *aws_connection_info
- name: try again but with ARN
lambda_policy:
function_name: "{{ lambda_result.configuration.function_arn }}"
state: present
statement_id: api-gateway-invoke-lambdas
action: lambda:InvokeFunction
principal: apigateway.amazonaws.com
source_arn: "arn:aws:execute-api:{{ aws_region }}:{{ aws_caller_facts.account }}:*/*"
<<: *aws_connection_info

Perhaps there is another reason your task failed? It would be fine to also document an abbreviated ARN example, but I don't think we should overwrite an example using a full ARN.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or adding another example using a full ARN that works would be fine.

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Jun 4, 2019
@acozine acozine added the needs_info This issue requires further information. Please answer any outstanding questions. label Jun 17, 2019
@ansibot
Copy link
Contributor

ansibot commented Jul 19, 2019

@darkhipo This pullrequest is waiting for your response. Please respond or the pullrequest will be closed.

click here for bot help

@darkhipo darkhipo closed this Jul 26, 2019
@ansible ansible locked and limited conversation to collaborators Aug 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.8 This issue/PR affects Ansible v2.8 aws bug This issue/PR relates to a bug. cloud docs This issue/PR relates to or includes documentation. docsite_pr This PR is created from documentation using the "Edit on GitHub" link. module This issue/PR relates to a module. needs_info This issue requires further information. Please answer any outstanding questions. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. new_contributor This PR is the first contribution by a new community member. small_patch stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants