Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VMware: Handle failure when timeout exceeded in shutdownguest #52952

Merged
merged 1 commit into from
Mar 11, 2019
Merged

VMware: Handle failure when timeout exceeded in shutdownguest #52952

merged 1 commit into from
Mar 11, 2019

Conversation

mtward
Copy link
Contributor

@mtward mtward commented Feb 25, 2019 •
edited
Loading

If the state_change_timeout was exceeded in shutdownguest, there was no failure. This adds a failure in that case.

SUMMARY
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

vmware_guest

ADDITIONAL INFORMATION

@mtward
update vmware_guest.py
6a55f96 
If the state_change_timeout was exceeded in shutdownguest, there was no failure.  This adds a failure in that case.
@ansibot
Copy link
Contributor

ansibot commented Feb 25, 2019

cc @Akasurde @Tomorrow9 @ckotte @dav1x @lparkes @nerzhul @pdellaert @warthog9
click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Feb 25, 2019

@mtward, just so you are aware we have a dedicated Working Group for vmware.
You can find other people interested in this in #ansible-vmware on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. small_patch support:community This issue/PR relates to code supported by the Ansible community. vmware VMware community labels Feb 25, 2019
@Akasurde Akasurde changed the title update vmware_guest.py VMware: Handle failure when timeout exceeded in shutdownguest Feb 26, 2019
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Mar 6, 2019
@Akasurde Akasurde removed the needs_triage Needs a first human triage before being processed. label Mar 11, 2019
@Akasurde
Copy link
Member

Closing and re-opening for CI trigger.

@Akasurde Akasurde closed this Mar 11, 2019
@Akasurde Akasurde reopened this Mar 11, 2019
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Mar 11, 2019
@Akasurde Akasurde merged commit 73ba6a9 into ansible:devel Mar 11, 2019
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@achinthagunasekara achinthagunasekara achinthagunasekara approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. new_contributor This PR is the first contribution by a new community member. small_patch support:community This issue/PR relates to code supported by the Ansible community. vmware VMware community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mtward @ansibot @Akasurde @achinthagunasekara