Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rds_instance] don't hardcode license_model choices #53409

Merged
merged 2 commits into from May 8, 2019
Merged

[rds_instance] don't hardcode license_model choices #53409

merged 2 commits into from May 8, 2019

Conversation

s-hertel
Copy link
Contributor

@s-hertel s-hertel commented Mar 6, 2019

SUMMARY

License models are not restricted to those listed here https://docs.aws.amazon.com/AmazonRDS/latest/APIReference/API_CreateDBInstance.html and there doesn't appear to be a good way to dynamically get the list of accepted licenses. The exception handling provides a helpful error if the wrong license is provided.

Fixes #53407

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

rds_instance

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 aws bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. labels Mar 6, 2019
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Mar 14, 2019
@s-hertel s-hertel requested a review from Akasurde April 22, 2019 15:05
@s-hertel
Copy link
Contributor Author

@Akasurde Do you mind taking a look at this?

@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Apr 22, 2019
@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label May 7, 2019
@Akasurde Akasurde force-pushed the remove_restrictive_choices_from_rds_instance branch from 2721d84 to ce01138 Compare May 8, 2019 07:18
@Akasurde Akasurde self-assigned this May 8, 2019
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels May 8, 2019
@Akasurde Akasurde merged commit 463a7ff into ansible:devel May 8, 2019
This was referenced Jun 4, 2019
Closed
Closed
ndclt pushed a commit to ndclt/ansible that referenced this pull request Jun 13, 2019
@s-hertel @ndclt
[rds_instance] don't hardcode license_model choices (ansible#53409)
30d0572 
* Don't hardcode license_model choices
@ansible ansible locked and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jillr jillr jillr approved these changes

@Akasurde Akasurde Awaiting requested review from Akasurde

Assignees

@Akasurde Akasurde

Labels
affects_2.8 This issue/PR affects Ansible v2.8 aws bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle specified license_model parameter for (at least) Postgresql
4 participants
@s-hertel @jillr @Akasurde @ansibot