Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New modules for Azure eventhub #55507

Closed
wants to merge 9 commits into from
Closed

New modules for Azure eventhub #55507

wants to merge 9 commits into from

Conversation

mmyyrroonn
Copy link
Contributor

@mmyyrroonn mmyyrroonn commented Apr 18, 2019 •
edited

SUMMARY
  • azure_rm_eventhub: create, update and delete an Azure eventhub.
  • azure_rm_eventhub_facts: gather facts for an a specific eventhub or all eventhub. Include showing sas policies and consumer groups.
ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

azure_rm_eventhub

ADDITIONAL INFORMATION
waiting for PR #55274 to be merged and rebase this PR

FanQiu added 3 commits April 18, 2019 16:39
support eventhub creation
a299b17 
gather facts for eventhub
support capture
cc3f493 
debug
a fix
72b4a5a 
adjust the name of the class
@ansibot
Copy link
Contributor

ansibot commented Apr 18, 2019

cc @haroldwongms @nitzmahone @trstringer @xscript @yuwzho @zikalino
click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Apr 18, 2019

@myronfanqiu this PR contains more than one new module.

Please submit only one new module per pull request. For a detailed explanation, please read the grouped modules documentation

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Apr 18, 2019

@myronfanqiu, just so you are aware we have a dedicated Working Group for azure.
You can find other people interested in this in #ansible-azure on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. affects_2.9 This issue/PR affects Ansible v2.9 azure cloud module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. labels Apr 18, 2019
@mmyyrroonn mmyyrroonn changed the title [WIP] new modules for Azure Eventhub [WIP] New modules for Azure eventhub Apr 18, 2019
@ansibleazurebot ansibleazurebot mentioned this pull request Apr 19, 2019
Closed
@mmyyrroonn mmyyrroonn changed the title [WIP] New modules for Azure eventhub New modules for Azure eventhub Apr 25, 2019
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. labels Apr 25, 2019
@mattclay mattclay added the ci_verified Changes made in this PR are causing tests to fail. label May 2, 2019
@ansibot
Copy link
Contributor

ansibot commented May 3, 2019

cc @yungezz
click here for bot help

@ansibot ansibot added stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. and removed needs_triage Needs a first human triage before being processed. labels May 3, 2019
@Fred-sun
Copy link
Contributor

Fred-sun commented May 5, 2019

@yungezz @yuwzho @zikalino Please help review this PR when you're available! Thanks!

@Fred-sun
Copy link
Contributor

@yungezz @zikalino @yuwzho Please take a review this PR when you're free! Thank you very much!

@Fred-sun
Copy link
Contributor

review_need

@Fred-sun
Copy link
Contributor

Fred-sun commented Jul 4, 2019

ping to review_need

@Fred-sun Fred-sun mentioned this pull request Jul 31, 2019
Closed
@Fred-sun
Copy link
Contributor

Waiting for PR #55274 to be merged and rebase this PR.

@ansibot
Copy link
Contributor

ansibot commented Jul 31, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_eventhub.py:0:0: E337 Argument 'encoding' in argument_spec found in capture_description defines type as 'str' but documentation doesn't define type

click here for bot help

@ansibot ansibot removed ci_verified Changes made in this PR are causing tests to fail. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Jul 31, 2019
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Aug 9, 2019
@goneri goneri added the ci_verified Changes made in this PR are causing tests to fail. label Oct 2, 2019
@ansibot
Copy link
Contributor

ansibot commented Dec 21, 2019

cc @gavinfish @haiyuazhang
click here for bot help

@mmyyrroonn mmyyrroonn closed this Mar 16, 2020
@ansible ansible locked and limited conversation to collaborators Apr 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 azure ci_verified Changes made in this PR are causing tests to fail. cloud has_issue module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. new_module This PR includes a new module. new_plugin This PR includes a new plugin. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mmyyrroonn @ansibot @Fred-sun @goneri @mattclay