Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

asa_og - update regex for description idempotency on legacy ASA #56728

Closed
wants to merge 1 commit into from
Closed

asa_og - update regex for description idempotency on legacy ASA #56728

wants to merge 1 commit into from

Conversation

lvrfrc87
Copy link
Contributor

@lvrfrc87 lvrfrc87 commented May 21, 2019 •
edited
Loading

On ASA Version 7, the object group description include columns (i.e. "description: "). This break idempotency.

SUMMARY

Update description regex to include optional columns

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

asa_og

ADDITIONAL INFORMATION
Cisco Adaptive Security Appliance Software Version 7.2(4)

object-group network test
 description: this is a test description

@lvrfrc87
Update regex for description
21bd2a4 
On ASA Version 7, the object group description include columns (i.e. "description: "). This break idempotency.
@lvrfrc87 lvrfrc87 changed the title Update regex for description asa_og - update regex for description idempotency on legacy ASA May 21, 2019
@ansibot
Copy link
Contributor

ansibot commented May 21, 2019

cc @federico87 @gdpak @ogenstad
click here for bot help

@ansibot
Copy link
Contributor

ansibot commented May 21, 2019

@FedericoOlivieri, just so you are aware we have a dedicated Working Group for network.
You can find other people interested in this in #ansible-network on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 asa Cisco ASA community bug This issue/PR relates to a bug. cisco Cisco technologies community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category small_patch support:community This issue/PR relates to code supported by the Ansible community. labels May 21, 2019
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label May 30, 2019
rohitthakur2590
rohitthakur2590 reviewed Jun 18, 2019
View reviewed changes
Copy link
Contributor

@rohitthakur2590 rohitthakur2590 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm +1

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Jun 18, 2019
@ansibot
Copy link
Contributor

ansibot commented Jun 26, 2019

cc @NilashishC
click here for bot help

@ansibot ansibot added the needs_repo This PR no longer has an associated branch as it was removed by the submitter. label Nov 28, 2019
@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Mar 27, 2020
@ansibot ansibot added collection Related to Ansible Collections work collection:cisco.asa needs_collection_redirect https://github.com/ansible/ansibullbot/blob/master/docs/collection_migration.md labels Apr 29, 2020
@danielmellado
Copy link
Contributor

Thank you very much for your interest in Ansible. This plugin is no longer maintained in this repository and has been migrated to https://github.com/ansible-collections/cisco.asa
Please re-submit this PR in the above repository.
If you have further questions please stop by IRC or the mailing list:

IRC: #ansible-network on irc.freenode.net
mailing list: https://groups.google.com/forum/#!forum/ansible-project

@ansible ansible locked and limited conversation to collaborators Jun 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rohitthakur2590 rohitthakur2590 rohitthakur2590 left review comments

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 asa Cisco ASA community bug This issue/PR relates to a bug. cisco Cisco technologies collection:cisco.asa collection Related to Ansible Collections work module This issue/PR relates to a module. needs_collection_redirect https://github.com/ansible/ansibullbot/blob/master/docs/collection_migration.md needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_repo This PR no longer has an associated branch as it was removed by the submitter. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. networking Network category small_patch stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lvrfrc87 @ansibot @danielmellado @rohitthakur2590