Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ios_config: Handle confirmation prompt after version change (#57745) #57749

Open
wants to merge 2 commits into
base: devel
from

Conversation

Projects
None yet
4 participants
@jrunu
Copy link

commented Jun 12, 2019

SUMMARY

Handle "Warning different version" prompt when saving config to Non-Volatile RAM on Cisco iOS devices.
Fixes #57745

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ios_config

ADDITIONAL INFORMATION

First time contributer to ansible. Has no idea what he's doing.

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 12, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 12, 2019

@jrunu, just so you are aware we have a dedicated Working Group for network.
You can find other people interested in this in #ansible-network on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 12, 2019

The test ansible-test sanity --test pylint [explain] failed with 3 errors:

lib/ansible/modules/network/ios/ios_config.py:396:0: anomalous-backslash-in-string Anomalous backslash in string: '\?'. String constant might be missing an r prefix.
lib/ansible/modules/network/ios/ios_config.py:396:0: anomalous-backslash-in-string Anomalous backslash in string: '\['. String constant might be missing an r prefix.
lib/ansible/modules/network/ios/ios_config.py:396:0: anomalous-backslash-in-string Anomalous backslash in string: '\]'. String constant might be missing an r prefix.

The test ansible-test sanity --test ansible-doc --python 3.8 [explain] failed with the error:

Output on stderr from ansible-doc is considered an error.

Command "ansible-doc -t module ios_config" returned exit status 0.
>>> Standard Error
<unknown>:396: SyntaxWarning: invalid escape sequence \?

The test ansible-test sanity --test import --python 3.8 [explain] failed with 1 error:

lib/ansible/modules/network/ios/ios_config.py:396:0: SyntaxWarning: invalid escape sequence \?

The test ansible-test sanity --test pep8 [explain] failed with 4 errors:

lib/ansible/modules/network/ios/ios_config.py:396:147: W605 invalid escape sequence '\?'
lib/ansible/modules/network/ios/ios_config.py:396:149: W605 invalid escape sequence '\['
lib/ansible/modules/network/ios/ios_config.py:396:158: W605 invalid escape sequence '\]'
lib/ansible/modules/network/ios/ios_config.py:396:161: E501 line too long (174 > 160 characters)

click here for bot help

@ansibot ansibot added needs_revision and removed core_review labels Jun 12, 2019

@ansible-zuul

This comment has been minimized.

Copy link

commented Jun 12, 2019

Build succeeded (third-party-check pipeline).

@pabelanger

This comment has been minimized.

Copy link
Contributor

commented Jun 12, 2019

Do you have a way to reproduce this, on an already configured ios device? If so, we can write a test here and add it to our integration test suite.

@ansibot ansibot removed the needs_triage label Jun 12, 2019

@jrunu

This comment has been minimized.

Copy link
Author

commented Jun 13, 2019

I played a bit in the lab and wasn't able to trigger this without performing an actual upgrade i.e. booting from one image into another. (I had ideas about messing with the version in the startup-config and reloading). So basically:

  1. Set the older to boot and load into it
  2. Set the newer version to boot
  3. Write config
  4. Reload
  5. Write config -> Warning prompt

The versions in my particular case were 15.4-M3(M8) to 15.6-M3(M6a). My resident cisco expert told me that this is an edge case. This warning isn't trigger with all minor release (not bugfix releases) upgrades, which I originally thought. There was at some point a breaking change in the configuration syntax. This is what triggers the warning. However I can't tell you the specific release. And for completeness sake, this was performed on a C886 device.

@pabelanger

This comment has been minimized.

Copy link
Contributor

commented Jun 13, 2019

Thanks for the detailed write up, that is what I was expecting. Today we don't do in-place upgrades of ios appliances for testing (in theory is something we could do). Lets wait until others review, to see if they have ideas how we could test.

@ganeshrn ganeshrn requested a review from Qalthos Jun 19, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 21, 2019

@ansibot ansibot added the stale_ci label Jun 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.