ios_config: Handle confirmation prompt after version change (#57745)

[jrunu]

SUMMARY

Handle "Warning different version" prompt when saving config to Non-Volatile RAM on Cisco iOS devices.
Fixes #57745

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

ios_config

ADDITIONAL INFORMATION

First time contributer to ansible. Has no idea what he's doing.

[ansibot]

cc @privateip @rcarrillocruz
click here for bot help

[ansibot]

@jrunu, just so you are aware we have a dedicated Working Group for network.
You can find other people interested in this in #ansible-network on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

[ansibot]

The test ansible-test sanity --test pylint [explain] failed with 3 errors:

lib/ansible/modules/network/ios/ios_config.py:396:0: anomalous-backslash-in-string Anomalous backslash in string: '\?'. String constant might be missing an r prefix.
lib/ansible/modules/network/ios/ios_config.py:396:0: anomalous-backslash-in-string Anomalous backslash in string: '\['. String constant might be missing an r prefix.
lib/ansible/modules/network/ios/ios_config.py:396:0: anomalous-backslash-in-string Anomalous backslash in string: '\]'. String constant might be missing an r prefix.

The test ansible-test sanity --test ansible-doc --python 3.8 [explain] failed with the error:

Output on stderr from ansible-doc is considered an error.

Command "ansible-doc -t module ios_config" returned exit status 0.
>>> Standard Error
<unknown>:396: SyntaxWarning: invalid escape sequence \?

The test ansible-test sanity --test import --python 3.8 [explain] failed with 1 error:

lib/ansible/modules/network/ios/ios_config.py:396:0: SyntaxWarning: invalid escape sequence \?

The test ansible-test sanity --test pep8 [explain] failed with 4 errors:

lib/ansible/modules/network/ios/ios_config.py:396:147: W605 invalid escape sequence '\?'
lib/ansible/modules/network/ios/ios_config.py:396:149: W605 invalid escape sequence '\['
lib/ansible/modules/network/ios/ios_config.py:396:158: W605 invalid escape sequence '\]'
lib/ansible/modules/network/ios/ios_config.py:396:161: E501 line too long (174 > 160 characters)

click here for bot help

[ansible-zuul]

Build succeeded (third-party-check pipeline).

• ansible-test-network-integration-ios-python27 : SUCCESS in 39m 56s
• ansible-test-network-integration-ios-python35 : SUCCESS in 45m 31s
• ansible-test-network-integration-ios-python36 : SUCCESS in 42m 47s
• ansible-test-network-integration-ios-python37 : SUCCESS in 51m 31s

[pabelanger]

Do you have a way to reproduce this, on an already configured ios device? If so, we can write a test here and add it to our integration test suite.

[jrunu]

I played a bit in the lab and wasn't able to trigger this without performing an actual upgrade i.e. booting from one image into another. (I had ideas about messing with the version in the startup-config and reloading). So basically:

1. Set the older to boot and load into it
2. Set the newer version to boot
3. Write config
4. Reload
5. Write config -> Warning prompt

The versions in my particular case were 15.4-M3(M8) to 15.6-M3(M6a). My resident cisco expert told me that this is an edge case. This warning isn't trigger with all minor release (not bugfix releases) upgrades, which I originally thought. There was at some point a breaking change in the configuration syntax. This is what triggers the warning. However I can't tell you the specific release. And for completeness sake, this was performed on a C886 device.

[pabelanger]

Thanks for the detailed write up, that is what I was expecting. Today we don't do in-place upgrades of ios appliances for testing (in theory is something we could do). Lets wait until others review, to see if they have ideas how we could test.

[ansibot]

cc @justjais
click here for bot help

[Qalthos]

recheck

[Qalthos]

You almost had it right the first time, but you needed to use a raw string instead (or double escape, but this is why we have raw strings)

Suggested change

	prompt='Overwrite the previous NVRAM configuration?[confirm]',
	prompt=r'Overwrite the previous NVRAM configuration\?\[confirm\]',

[ansible-zuul]

Build succeeded (third-party-check pipeline).

• ansible-test-network-integration-ios-python27 : SUCCESS in 54m 46s
• ansible-test-network-integration-ios-python35 : SUCCESS in 57m 38s
• ansible-test-network-integration-ios-python36 : SUCCESS in 1h 01m 45s
• ansible-test-network-integration-ios-python37 : SUCCESS in 59m 35s
• ansible-test-network-integration-ios-python38 : SUCCESS in 1h 25m 57s

[danielmellado]

Thank you very much for your interest in Ansible. This plugin is no longer maintained in this repository and has been migrated to https://github.com/ansible-collections/cisco.ios
Please re-submit this PR in the above repository.
If you have further questions please stop by IRC or the mailing list:

IRC: #ansible-network on irc.freenode.net
mailing list: https://groups.google.com/forum/#!forum/ansible-project