Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checkpoint facts module to handle all available api's show tasks #58036

Closed
wants to merge 6 commits into from
Closed

Checkpoint facts module to handle all available api's show tasks #58036

wants to merge 6 commits into from

Conversation

justjais
Copy link
Contributor

SUMMARY

PR to introduce CP facts module which retrieves and show existing objects on Checkpoint over Web Services API.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

checkpoint

ADDITIONAL INFORMATION

@justjais
checkpoint facts module
55ec80f 
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
@justjais
checkpoint facts module
4565440 
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
@justjais
checkpoint facts module
5e9981b 
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
@justjais
checkpoint facts module
2064a73 
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
@ansibot
Copy link
Contributor

ansibot commented Jun 19, 2019

@justjais, just so you are aware we have a dedicated Working Group for network.
You can find other people interested in this in #ansible-network on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. labels Jun 19, 2019
@justjais
checkpoint facts module
f0945b9 
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
@justjais
Copy link
Contributor Author

cc. @chkp-orso

@justjais
checkpoint facts module
14f58bc 
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
@ansibot
Copy link
Contributor

ansibot commented Jun 19, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 2 errors:

lib/ansible/modules/network/checkpoint/cp_get_facts.py:0:0: E319 RETURN.cp_get_facts.eturned: extra keys not allowed @ data['cp_get_facts']['eturned']. Got 'always.'
lib/ansible/modules/network/checkpoint/cp_get_facts.py:0:0: E319 RETURN.cp_get_facts.returned: required key not provided @ data['cp_get_facts']['returned']. Got None

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Jun 19, 2019
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jun 27, 2019
@ansibot ansibot added the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Aug 24, 2019
@ansibot ansibot added collection Related to Ansible Collections work collection:check_point.mgmt needs_collection_redirect https://github.com/ansible/ansibullbot/blob/master/docs/collection_migration.md labels Apr 29, 2020
@justjais
Copy link
Contributor Author

Closing this as the CP contents are already moved to their specific GH repo

@justjais justjais closed this May 19, 2020
@justjais justjais deleted the cp_command branch May 19, 2020 06:23
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Jun 2, 2020
@ansible ansible locked and limited conversation to collaborators Jun 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@maxamillion maxamillion Awaiting requested review from maxamillion

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 ci_verified Changes made in this PR are causing tests to fail. collection Related to Ansible Collections work module This issue/PR relates to a module. needs_collection_redirect https://github.com/ansible/ansibullbot/blob/master/docs/collection_migration.md needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. networking Network category new_module This PR includes a new module. new_plugin This PR includes a new plugin. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@justjais @ansibot @sivel