Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fortinet's new module for fortios_wireless_controller_hotspot20_anqp_ip_address_type #61088

Merged
merged 3 commits into from Aug 23, 2019
Merged

Fortinet's new module for fortios_wireless_controller_hotspot20_anqp_ip_address_type #61088

merged 3 commits into from Aug 23, 2019

Conversation

frankshen01
Copy link
Contributor

SUMMARY

Fortinet is adding Ansible support for FortiOS and FortiGate products. This module follows the same structure, guidelines and ideas given in previous approved module for a parallel feature of FortiGate (user device): #56447
In this case we are providing a different functionality: "Fortios Wireless Controller Hotspot20 ANQP IP Address Type".

Please note that this will be part of other modules to come for FortiGate, including different functionalities: system, wireless-controller, firewall, webfilter, ips, web-proxy, wanopt, application, dlp spamfilter, log, vpn, certificate, user, dnsfilter, antivirus, report, waf, authentication, switch controller, endpoint-control and router. We plan to follow the same style, structure and usage as in the previous module in order to make it easier to comply with Ansible guidelines.

This PR has been updated according to suggestions and code reviews given in previous submissions of Fortinet modules.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

fortios_wireless_controller_hotspot20_anqp_ip_address_type

ANSIBLE VERSION
ansible 2.8.2
python version = 3.7.3 (default, Apr  22 2019, 12:09:22) [GCC 8.3.0]

@ansibot
Copy link
Contributor

ansibot commented Aug 22, 2019

@ansibot
Copy link
Contributor

ansibot commented Aug 22, 2019

@frankshen01, just so you are aware we have a dedicated Working Group for network.
You can find other people interested in this in #ansible-network on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 core_review In order to be merged, this PR must follow the core review workflow. fortios Fortios community module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category new_contributor This PR is the first contribution by a new community member. new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Aug 22, 2019
@ansibot
Copy link
Contributor

ansibot commented Aug 22, 2019

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/network/fortios/fortios_wireless_controller_hotspot20_anqp_ip_address_type.py:249:5: E122 continuation line missing indentation or outdented

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Aug 22, 2019
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Aug 22, 2019
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 22, 2019
@rohitthakur2590 rohitthakur2590 merged commit 30c9abf into ansible:devel Aug 23, 2019
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Aug 26, 2019
adharshsrivatsr pushed a commit to adharshsrivatsr/ansible that referenced this pull request Sep 3, 2019
…ip_address_type (ansible#61088)

* Fortinet's new module for fortios_wireless_controller_hotspot20_anqp_ip_address_type

* Update fortios_wireless_controller_hotspot20_anqp_ip_address_type.py

* Update fortios_wireless_controller_hotspot20_anqp_ip_address_type.py
@ansible ansible locked and limited conversation to collaborators Sep 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.9 This issue/PR affects Ansible v2.9 core_review In order to be merged, this PR must follow the core review workflow. fortios Fortios community module This issue/PR relates to a module. networking Network category new_contributor This PR is the first contribution by a new community member. new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants