New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fortinet's new module for fortios_wireless_controller_hotspot20_anqp_ip_address_type #61088
Merged
rohitthakur2590
merged 3 commits into
ansible:devel
from
frankshen01:fortios_wireless_controller_hotspot20_anqp_ip_address_type
Aug 23, 2019
Merged
Fortinet's new module for fortios_wireless_controller_hotspot20_anqp_ip_address_type #61088
rohitthakur2590
merged 3 commits into
ansible:devel
from
frankshen01:fortios_wireless_controller_hotspot20_anqp_ip_address_type
Aug 23, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@frankshen01, just so you are aware we have a dedicated Working Group for network. |
ansibot
added
affects_2.9
This issue/PR affects Ansible v2.9
core_review
In order to be merged, this PR must follow the core review workflow.
fortios
Fortios community
module
This issue/PR relates to a module.
needs_triage
Needs a first human triage before being processed.
networking
Network category
new_contributor
This PR is the first contribution by a new community member.
new_module
This PR includes a new module.
new_plugin
This PR includes a new plugin.
support:community
This issue/PR relates to code supported by the Ansible community.
support:core
This issue/PR relates to code supported by the Ansible Engineering Team.
test
This PR relates to tests.
labels
Aug 22, 2019
The test
|
ansibot
added
ci_verified
Changes made in this PR are causing tests to fail.
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR.
and removed
core_review
In order to be merged, this PR must follow the core review workflow.
labels
Aug 22, 2019
ansibot
removed
the
ci_verified
Changes made in this PR are causing tests to fail.
label
Aug 22, 2019
ansibot
added
core_review
In order to be merged, this PR must follow the core review workflow.
and removed
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR.
labels
Aug 22, 2019
rohitthakur2590
approved these changes
Aug 23, 2019
sivel
removed
the
needs_triage
Needs a first human triage before being processed.
label
Aug 26, 2019
adharshsrivatsr
pushed a commit
to adharshsrivatsr/ansible
that referenced
this pull request
Sep 3, 2019
…ip_address_type (ansible#61088) * Fortinet's new module for fortios_wireless_controller_hotspot20_anqp_ip_address_type * Update fortios_wireless_controller_hotspot20_anqp_ip_address_type.py * Update fortios_wireless_controller_hotspot20_anqp_ip_address_type.py
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
affects_2.9
This issue/PR affects Ansible v2.9
core_review
In order to be merged, this PR must follow the core review workflow.
fortios
Fortios community
module
This issue/PR relates to a module.
networking
Network category
new_contributor
This PR is the first contribution by a new community member.
new_module
This PR includes a new module.
new_plugin
This PR includes a new plugin.
support:community
This issue/PR relates to code supported by the Ansible community.
support:core
This issue/PR relates to code supported by the Ansible Engineering Team.
test
This PR relates to tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fortinet is adding Ansible support for FortiOS and FortiGate products. This module follows the same structure, guidelines and ideas given in previous approved module for a parallel feature of FortiGate (user device): #56447
In this case we are providing a different functionality: "Fortios Wireless Controller Hotspot20 ANQP IP Address Type".
Please note that this will be part of other modules to come for FortiGate, including different functionalities: system, wireless-controller, firewall, webfilter, ips, web-proxy, wanopt, application, dlp spamfilter, log, vpn, certificate, user, dnsfilter, antivirus, report, waf, authentication, switch controller, endpoint-control and router. We plan to follow the same style, structure and usage as in the previous module in order to make it easier to comply with Ansible guidelines.
This PR has been updated according to suggestions and code reviews given in previous submissions of Fortinet modules.
ISSUE TYPE
COMPONENT NAME
fortios_wireless_controller_hotspot20_anqp_ip_address_type
ANSIBLE VERSION