Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

threat_layer module #61389

Merged
merged 4 commits into from Aug 29, 2019

Conversation

@chkp-amiads
Copy link
Contributor

commented Aug 27, 2019

SUMMARY

Checkpoint threat_layer module

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

cp_mgmt_threat_layer

ADDITIONAL INFORMATION

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Aug 27, 2019

@chkp-amiads this PR contains more than one new module.

Please submit only one new module per pull request. For a detailed explanation, please read the grouped modules documentation

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Aug 27, 2019

@chkp-amiads, just so you are aware we have a dedicated Working Group for network.
You can find other people interested in this in #ansible-network on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

chkp-amiads added 2 commits Aug 28, 2019
state: present
- name: set-threat-layer
cp_mgmt_threat_layer:

This comment has been minimized.

Copy link
@justjais

justjais Aug 29, 2019

Contributor

@chkp-amiads here, set operation is doing nothing extra, can u update the example

This comment has been minimized.

Copy link
@chkp-amiads

chkp-amiads Aug 29, 2019

Author Contributor

In our API the threat layer doesnt have many attributes to set (only new-name, color, tags) since we dont support new-name and the others are generic ones, i think we can release this module as is.
Or told me there are vendors who doesnt have 3 examples per module. Can we skip this one?

@justjais justjais merged commit 07c288f into ansible:devel Aug 29, 2019

1 check passed

Shippable Run 140874 status is SUCCESS.
Details

@sivel sivel removed the needs_triage label Aug 29, 2019

adharshsrivatsr added a commit to adharshsrivatsr/ansible that referenced this pull request Sep 3, 2019
threat_layer module (ansible#61389)
* threat_layer module

* list to dict

* fix example

* remove set example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.