Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

threat_layer module #61389

Merged
merged 4 commits into from
Aug 29, 2019
Merged

threat_layer module #61389

merged 4 commits into from
Aug 29, 2019

Conversation

chkp-amiads
Copy link
Contributor

SUMMARY

Checkpoint threat_layer module

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

cp_mgmt_threat_layer

ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Aug 27, 2019

@chkp-amiads this PR contains more than one new module.

Please submit only one new module per pull request. For a detailed explanation, please read the grouped modules documentation

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Aug 27, 2019

@chkp-amiads, just so you are aware we have a dedicated Working Group for network.
You can find other people interested in this in #ansible-network on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. networking Network category new_contributor This PR is the first contribution by a new community member. new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. labels Aug 27, 2019
justjais
justjais suggested changes Aug 29, 2019
View reviewed changes
lib/ansible/modules/network/checkpoint/cp_mgmt_threat_layer.py Outdated
state: present

- name: set-threat-layer
cp_mgmt_threat_layer:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chkp-amiads here, set operation is doing nothing extra, can u update the example

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In our API the threat layer doesnt have many attributes to set (only new-name, color, tags) since we dont support new-name and the others are generic ones, i think we can release this module as is.
Or told me there are vendors who doesnt have 3 examples per module. Can we skip this one?

@ansibot ansibot removed the new_contributor This PR is the first contribution by a new community member. label Aug 29, 2019
@justjais justjais merged commit 07c288f into ansible:devel Aug 29, 2019
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Aug 29, 2019
adharshsrivatsr pushed a commit to adharshsrivatsr/ansible that referenced this pull request Sep 3, 2019
@chkp-amiads @adharshsrivatsr
threat_layer module (ansible#61389)
24d800a 
* threat_layer module

* list to dict

* fix example

* remove set example
anas-shami pushed a commit to anas-shami/ansible that referenced this pull request Sep 23, 2019
@chkp-amiads @anas-shami
threat_layer module (ansible#61389)
b8d65ff 
* threat_layer module

* list to dict

* fix example

* remove set example
@ansible ansible locked and limited conversation to collaborators Oct 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@justjais justjais justjais approved these changes

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. networking Network category new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chkp-amiads @ansibot @justjais @sivel