Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable-2.8] aws_s3 - wait for the bucket before setting ACLs (#61735) #61769

Merged
merged 2 commits into from
Sep 4, 2019
Merged

[stable-2.8] aws_s3 - wait for the bucket before setting ACLs (#61735) #61769

merged 2 commits into from
Sep 4, 2019

Conversation

samdoran
Copy link
Contributor

@samdoran samdoran commented Sep 4, 2019

SUMMARY

Backport of #61735 for Ansible 2.8

This is to address test failures in CI. If we don't want to backport this since it's not a critical bug, we will need to mark the tests as unstable.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/modules/cloud/amazon/aws_s3.py

@s-hertel @samdoran
[stable-2.8] aws_s3 - wait for the bucket before setting ACLs (ansibl…
51de354 
…e#61735)

* Wait for the bucket to become available if possible before setting ACLs
(cherry picked from commit 91ccb03)

Co-authored-by: Sloane Hertel <shertel@redhat.com>
@ansibot
Copy link
Contributor

ansibot commented Sep 4, 2019

cc @lwade @s-hertel
click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Sep 4, 2019

@samdoran, just so you are aware we have a dedicated Working Group for aws.
You can find other people interested in this in #ansible-aws on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 aws backport This PR does not target the devel branch. bug This issue/PR relates to a bug. cloud core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Sep 4, 2019
@abadger abadger merged commit 05d084b into ansible:stable-2.8 Sep 4, 2019
@abadger
Copy link
Contributor

abadger commented Sep 4, 2019

Merged for the 2.8.5 release. Thanks @samdoran and @s-hertel :-)

@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Sep 6, 2019
@ansible ansible locked and limited conversation to collaborators Oct 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 aws backport This PR does not target the devel branch. bug This issue/PR relates to a bug. cloud core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@samdoran @ansibot @abadger @sivel @s-hertel