fix: enable wait_for_ip for existing vm customization

[wilmardo]

SUMMARY

Enable wait_for_ip_address when customizing an existing VM.
Used the same logic as deploy_vm:
https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/cloud/vmware/vmware_guest.py#L2471

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

vmware_guest

ADDITIONAL INFORMATION

This is for example useful when restoring a snapshot and customizing the network afterwards.

[ansibot]

cc @Akasurde @Tomorrow9 @goneri @lparkes @nerzhul @pdellaert @pgbidkar @warthog9
click here for bot help

[ansibot]

@wilmardo, just so you are aware we have a dedicated Working Group for vmware.
You can find other people interested in this in #ansible-vmware on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

[goneri]

Hi @wilmardo!

I'm not sure we need this change since this seems to be an issue vmware_guest_tools_wait can address? Is there any cases where it would not be enough?

[wilmardo]

Hi @goneri!

I ran into this since I wanted to create a machine with network customizations, boot the vm once, shutdown, create a snapshot and then apply a password customization on the existing vm and wait for it to boot and complete.

I could fix it with vmware_guest_tools_wait but it seems wrong to have the options available in the module but they are silently ignored when doing customizations on an existing VM.

[Akasurde]

@wilmardo Could you please rebase this PR? @goneri This can be helpful in case #66662.

[wilmardo]

@Akasurde Will do today :)

[wilmardo]

@Akasurde @goneri Ready for review again 🎉

[ansible-zuul]

Build succeeded (third-party-check pipeline).

• ansible-test-cloud-integration-vcenter_only-python36 : SUCCESS in 30m 36s (non-voting)
• ansible-test-cloud-integration-vcenter_1esxi-python36 : FAILURE in 1h 49m 00s (non-voting)

[goneri]

Hi!

Thank you for your PR. Since March 2, 2020, the Ansible team does not accept any new changes on the VMware modules on the core ansible/ansible repository.
The development continue but in the new VMware collection repository: https://github.com/ansible-collections/vmware
We have no way to properly migrate a Github issue between the two projects. Could you please reopen the PR there? https://github.com/ansible-collections/vmware

Links:

• https://groups.google.com/forum/#!msg/ansible-devel/6UAfogEDtG8/wMTgxBGWCgAJ
• https://github.com/ansible-collections/overview/blob/master/README.rst

needs_info

[ansibot]

@wilmardo This pullrequest is waiting for your response. Please respond or the pullrequest will be closed.

click here for bot help

[ansibot]

@wilmardo You have not responded to information requests in this pullrequest so we will assume it no longer affects you. If you are still interested in this, please create a new pullrequest with the requested information.

click here for bot help