Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eos_config: Added fix for bug #54400 - support for !! in config mode #63694

Merged
merged 3 commits into from
Jan 17, 2020
Merged

eos_config: Added fix for bug #54400 - support for !! in config mode #63694

merged 3 commits into from
Jan 17, 2020

Conversation

GomathiselviS
Copy link
Contributor

@GomathiselviS GomathiselviS commented Oct 18, 2019 •
edited
Loading

SUMMARY

Fixes bug #54400

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/module_utils/network/common/config.py

@ansibot
Copy link
Contributor

ansibot commented Oct 18, 2019

cc @NilashishC @Qalthos @danielmellado @ganeshrn @justjais @privateip @trishnaguha
click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Oct 18, 2019

@GomathiselviS, just so you are aware we have a dedicated Working Group for network.
You can find other people interested in this in #ansible-network on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category support:network This issue/PR relates to code supported by the Ansible Network Team. labels Oct 18, 2019
@ansible-zuul
Copy link

ansible-zuul bot commented Oct 18, 2019

Build succeeded (third-party-check pipeline).

@justjais justjais removed the needs_triage Needs a first human triage before being processed. label Oct 23, 2019
@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Oct 31, 2019
@ansibot ansibot removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Dec 11, 2019
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Dec 21, 2019
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jan 14, 2020
@Qalthos
Copy link
Contributor

Qalthos commented Jan 14, 2020

recheck

@ansible-zuul
Copy link

ansible-zuul bot commented Jan 14, 2020

Build failed (third-party-check pipeline) integration testing with
Ansible.

@GomathiselviS
Copy link
Contributor Author

recheck

@ansible-zuul
Copy link

ansible-zuul bot commented Jan 16, 2020

Build succeeded (third-party-check pipeline).

@Qalthos
Copy link
Contributor

Qalthos commented Jan 16, 2020

rebuild_merge

@ansibot ansibot added shipit This PR is ready to be merged by Core needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. shipit This PR is ready to be merged by Core labels Jan 16, 2020
@GomathiselviS
Copy link
Contributor Author

rebuild_merge

@Qalthos Qalthos merged commit 7ddf747 into ansible:devel Jan 17, 2020
pabelanger added a commit to pabelanger/ansible that referenced this pull request Jan 18, 2020
@pabelanger
Revert "eos_config: Added fix for bug ansible#54400 - support for !! …
2357bea 
…in config mode (ansible#63694)"

This actually breaks iosxr_config, revert for now to make tests passing
again.

This reverts commit 7ddf747.
@pabelanger pabelanger mentioned this pull request Jan 18, 2020
Merged
pabelanger added a commit that referenced this pull request Jan 18, 2020
@pabelanger
Revert "eos_config: Added fix for bug #54400 - support for !! in conf…
f46af19 
…ig mode (#63694)" (#66591)

This actually breaks iosxr_config, revert for now to make tests passing
again.

This reverts commit 7ddf747.
NehaKembalkarA10 pushed a commit to NehaKembalkarA10/ansible that referenced this pull request Jan 30, 2020
@GomathiselviS @NehaKembalkarA10
eos_config: Added fix for bug ansible#54400 - support for !! in confi…
783be49 
…g mode (ansible#63694)

* Corrected lint errors

* Added fix for bug # 54400

* Resolving conflicts
NehaKembalkarA10 pushed a commit to NehaKembalkarA10/ansible that referenced this pull request Jan 30, 2020
@pabelanger @NehaKembalkarA10
Revert "eos_config: Added fix for bug ansible#54400 - support for !! …
aba83ed 
…in config mode (ansible#63694)" (ansible#66591)

This actually breaks iosxr_config, revert for now to make tests passing
again.

This reverts commit 7ddf747.
@ansible ansible locked and limited conversation to collaborators Feb 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Qalthos Qalthos Qalthos approved these changes

@ganeshrn ganeshrn Awaiting requested review from ganeshrn

Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. networking Network category support:network This issue/PR relates to code supported by the Ansible Network Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GomathiselviS @ansibot @Qalthos @justjais