vmware_guest: Enable setting mac address when cloning from VM or template

[wkoot]

SUMMARY

Rebased zeot/devel from #51368 on ansible/devel. Original summary:

The method previously used for device changes when cloning was deprecated in vCenter 6.0. Even though it still works on vCenter 6.5.0, the vcsim did not apply these changes (resolved in govmomi master now, but not released).

For future proofing and testability, the new method of implementing device changes on clone is used when applying device changes when vCenter version 6.0 or greater is detected.

Fixes #51123 and fixes #51124

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

lib/ansible/modules/cloud/vmware/vmware_guest.py

ADDITIONAL INFORMATION

I wasn't able to use the suggested prepare_vmware_roles, but tested against a local vsphere instead

[ansibot]

cc @Akasurde @Tomorrow9 @goneri @lparkes @nerzhul @pdellaert @pgbidkar @warthog9
click here for bot help

[ansibot]

@wkoot, just so you are aware we have a dedicated Working Group for vmware.
You can find other people interested in this in #ansible-vmware on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

[goneri]

Thanks for the rebase, and the update of the functional tests. It looks much better. But I've a little problem with the test itself :-(.

[goneri]

Oh, I get the following error :-(

fatal: [testhost]: FAILED! => {
    "changed": false,
    "invocation": {
        "module_args": {
            "annotation": null,
            "cdrom": [],
            "cluster": null,
            "convert": null,
            "customization": {},
            "customization_spec": null,
            "customvalues": [],
            "datacenter": "DC0",
            "datastore": null,
            "delete_from_inventory": false,
            "disk": [],
            "esxi_hostname": null,
            "folder": "F0",
            "force": false,
            "guest_id": null,
            "hardware": {},
            "hostname": "vcenter.test",
            "is_template": false,
            "linked_clone": false,
            "name": "test_vm1",
            "name_match": "first",
            "networks": [
                {
                    "gateway": "192.168.10.254",
                    "ip": "192.168.10.10",
                    "mac": "aa:bb:cc:dd:aa:b0",
                    "name": "VM Network",
                    "netmask": "255.255.255.0",
                    "type": "static"
                }
            ],
            "password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER",
            "port": 443,
            "proxy_host": null,
            "proxy_port": null,
            "resource_pool": null,
            "snapshot_src": null,
            "state": "poweredoff",
            "state_change_timeout": 0,
            "template": "DC0_H0_VM0",
            "use_instance_uuid": false,
            "username": "administrator@vsphere.local",
            "uuid": null,
            "validate_certs": false,
            "vapp_properties": [],
            "wait_for_customization": false,
            "wait_for_customization_timeout": 3600,
            "wait_for_ip_address": false,
            "wait_for_ip_address_timeout": 300
        }
    },
    "msg": "Failed to create a virtual machine : Customization of the guest operating system 'debian8_64Guest' is not supported in this configuration. Microsoft Vista (TM) and Linux guests with Logical Volume Manager are supported only for recent ESX host and VMware Tools versions. Refer to vCenter documentation for supported configurations."  
}

clone_customize_guest_test.yml works fine with the same configuration.

[wkoot]

That's weird. Was the test vm not turned off when you ran the test?

[goshansp]

Workaround: Remove network interface from vm manually before converting it to template. I am now able to clone and customize interface/mac using Ansible 2.8.1 against vSphere 6.5 spinning RHEL7.7 ... Great work you people are doing - Thanks and much appreciation.

[goneri]

Hi!

Thank you for your PR. Since March 2, 2020, the Ansible team does not accept any new changes on the VMware modules on the core ansible/ansible repository.
The development continue but in the new VMware collection repository: https://github.com/ansible-collections/vmware
We have no way to properly migrate a Github issue between the two projects. Could you please reopen the PR there? https://github.com/ansible-collections/vmware

Links:

• https://groups.google.com/forum/#!msg/ansible-devel/6UAfogEDtG8/wMTgxBGWCgAJ
• https://github.com/ansible-collections/overview/blob/master/README.rst

needs_info

[ansibot]

@wkoot This pullrequest is waiting for your response. Please respond or the pullrequest will be closed.

click here for bot help

[wkoot]

@ansibot fuck it