Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add changed condition when update azure_rm_virtualnetworkpeering #66230

Merged
merged 1 commit into from
Jan 25, 2020
Merged

Add changed condition when update azure_rm_virtualnetworkpeering #66230

merged 1 commit into from
Jan 25, 2020

Conversation

Fred-sun
Copy link
Contributor

@Fred-sun Fred-sun commented Jan 7, 2020

SUMMARY

The enhancement would be to enforce peerings where if either the remote or local vnet is disconnected to delete and recreate. Try to fixes #66031

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

azure_rm_virtualnetworkpeering

ADDITIONAL INFORMATION

@Fred-sun Fred-sun mentioned this pull request Jan 7, 2020
Closed
@ansibot
Copy link
Contributor

ansibot commented Jan 7, 2020

cc @gavinfish @haiyuazhang @haroldwongms @nitzmahone @yungezz @yuwzho @zikalino
click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Jan 7, 2020

@Fred-sun, just so you are aware we have a dedicated Working Group for azure.
You can find other people interested in this in #ansible-azure on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 azure bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. has_issue module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. small_patch support:community This issue/PR relates to code supported by the Ansible community. labels Jan 7, 2020
@Fred-sun
Copy link
Contributor Author

Fred-sun commented Jan 7, 2020

ready_for_review

@ansibleazurebot ansibleazurebot mentioned this pull request Jan 8, 2020
Closed
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jan 15, 2020
@exodusftw
Copy link

@Fred-sun - it looks like you need to close/re-open this PR to force through CI testing again

@zikalino zikalino merged commit f1ec484 into ansible:devel Jan 25, 2020
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Jan 28, 2020
@ansible ansible locked and limited conversation to collaborators Feb 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zikalino zikalino zikalino approved these changes

Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 azure bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. has_issue module This issue/PR relates to a module. small_patch stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Azure VNet Peering disconnected state
5 participants
@Fred-sun @ansibot @exodusftw @zikalino @sivel