Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Botmeta and runtime file to reflect the dellemc collections path #71875

Closed
wants to merge 1 commit into from

Conversation

rajeevarakkal
Copy link
Contributor

SUMMARY

Update Botmeta and ansible_runtime_builtin files to add migrated_to: and redirected_to: location to dellemc.openmanage collections

ISSUE TYPE
  • Docs Pull Request
ADDITIONAL INFORMATION
dellemc modules has been migrated to `dellemc.openmanage` collections in ansible galaxy

@ansibot
Copy link
Contributor

ansibot commented Sep 23, 2020

@rajeevarakkal this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@ansibot ansibot added affects_2.11 docs This issue/PR relates to or includes documentation. merge_commit This PR contains at least one merge commit. Please resolve! needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Sep 23, 2020
@ansibot ansibot added botmeta This PR modifies the BOTMETA.yml and this requires special attention! core_review In order to be merged, this PR must follow the core review workflow. runtime ansible_builtin_runtime.yml and removed merge_commit This PR contains at least one merge commit. Please resolve! needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Sep 23, 2020
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Sep 23, 2020
@sivel
Copy link
Member

sivel commented Sep 23, 2020

I'm not sure that this is correct. These modules actively exist in community.general, which means that Ansible 2.10.0 has shipped with them in that location.

If they are being migrated, then they should be removed from community.general, and community.general should have these redirects. They likely shouldn't be redirected from here.

cc @abadger @gundalow

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Sep 23, 2020
@abadger
Copy link
Contributor

abadger commented Sep 23, 2020

BOTMETA might need to be updated here especially if the bot running on ansible/ansible is telling people where to redirect their issues and PRs. @gundalow and @samdoran do you know how the bot operates in that regard?

The current plan for the runtime.yml changes are indeed that you should apply those to community.general. Unless nitzmahone starts allowing changes to the runtime.yml in the future (something he's against), it will be a redirect chain: ansible-base's runtime.yml redirects to community.general's runtime.yml which redirects to the new collections. gundalow and felixfontein probably know that process best right now EDIT: I see gundalow replied with a link to this process

@sivel
Copy link
Member

sivel commented Sep 23, 2020

The bot doesn't rely solely on BOTMETA, nor the runtime.yml for redirection. The bot has a lot of logic that exceeds these static files. cc @mkrizek

@mkrizek
Copy link
Contributor

mkrizek commented Sep 24, 2020

Although there is search_by_botmeta_migrated_to function implemented in the ansibot's codebase (ansible/ansibullbot) it is not used and the bot does not in fact use BOTMETA.yml nor ansible_builtin_runtime.yml at all for "redirect comments". The bot uses galaxy API to figure out where plugins moved instead.

@abadger
Copy link
Contributor

abadger commented Sep 24, 2020

Cool, there doesn't seem to be anything needed in this patch, then

@samdoran samdoran closed this Sep 24, 2020
@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label Sep 24, 2020
@ansible ansible locked and limited conversation to collaborators Oct 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.11 botmeta This PR modifies the BOTMETA.yml and this requires special attention! core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. has_issue runtime ansible_builtin_runtime.yml support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants