-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove DellEMC collections from community.general collectons #948
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding negative review to prevent premature merge. dellemc.openmanage
is not included in Ansible (yet), and we haven't decided how to proceed with such removals yet.
Hi @felixfontein , are you referring to this PR ansible/ansible#71875 completion? |
@rajeevarakkal no, I'm referring to the 'move content between collections where the target collection is not part of Ansible' policy which hasn't been decided yet. Also, I don't think that PR in ansible/ansible will get merged, since ansible_builtin_runtime.yml is essentially frozen. |
See ansible/community#539 (comment), "to discuss: what happens when the target collection is (not yet) contained in Ansible?". |
@felixfontein , i didn't get exactly target collection not |
No, I mean Ansible itself (https://pypi.org/project/ansible/) - it was formerly called ACD (Ansible Community Distribution), maybe that name is more familiar to you. The collections included in Ansible 2.10 are listed here: https://github.com/ansible-community/ansible-build-data/blob/main/2.10/ansible.in |
@felixfontein , Thanks, will go through this once. |
|
@gundalow , The three contributed modules from dellemc -ie There been a request/communicaton earlier that Since we have our collections available at |
@rajeevarakkal you still need to update the files @gundalow referenced before this can get merged |
There seems to be no modules called |
@rajeevarakkal could you please update/adjust this PR in a similar manner to e53f153 ? The removal would happen in community.general 3.0.0. Once this PR is in a good shape and ansible-community/ansible-build-data#58 has been merged, we can merge it and add an announcement to the next community.general 2.x.y release announcing this removal. (And of course update ansible/ansible#73046.) |
@rajeevarakkal the PR now has conflicts, could you please rebase it? |
on it. Resolving the same |
@rajeevarakkal this PR contains the following merge commits: Please rebase your branch to remove these commits. |
@rajeevarakkal This PR was evaluated as a potentially problematic PR for the following reasons:
Such PR can only be merged by human. Contact a Core team member to review this PR on IRC: |
@rajeevarakkal could you please do a proper rebase to remove the merge commits, and remove all changes from this PR that do not belong in it (like the changes to .azure-pipelines/ and test/utils/)? Thanks. |
@felixfontein Looks like rebase is running into chained conflicts. I will go ahead nd create a fresh PR and provide the link here. Is that fine? |
@rajeevarakkal that's fine as well! |
@felixfontein here is the new PR #1699 |
New PR created due to multiple conflict here - #1699 |
SUMMARY
Need to get removed the dellemc collections community general repository as dellemc all modules are now available in Galaxy
dellemc.openmanage
collection.ISSUE TYPE
ADDITIONAL INFORMATION