Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update or remove ui launch button test #11433

Closed
3 tasks done
jakemcdermott opened this issue Dec 8, 2021 · 0 comments
Closed
3 tasks done

Update or remove ui launch button test #11433

jakemcdermott opened this issue Dec 8, 2021 · 0 comments

Comments

@jakemcdermott
Copy link
Contributor

jakemcdermott commented Dec 8, 2021

Please confirm the following

  • I agree to follow this project's code of conduct.
  • I have checked the current issues for duplicates.
  • I understand that AWX is open source software provided for free and that I am not entitled to status updates or other assurances.

Summary

One of the assertions in the launch button test isn't actually verifying the correct behavior.

...
    const button = wrapper.find('button');
    await act(() => button.prop('onClick')());
    wrapper.update();
    expect(wrapper.find('button').prop('disabled')).toEqual(false);
  });
...

This is something @AlexSCorey spotted during PR review and we should definitely address it when we can. We'll want to either remove the test case (if it is no longer a valid test case) or update the assertion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants