Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

satellite custom group_prefix not getting applied to all groups #7031

Closed
jladdjr opened this issue May 14, 2020 · 3 comments
Closed

satellite custom group_prefix not getting applied to all groups #7031

jladdjr opened this issue May 14, 2020 · 3 comments

Comments

@jladdjr
Copy link
Contributor

jladdjr commented May 14, 2020

ISSUE TYPE
  • Bug Report
SUMMARY

The satellite6_group_prefix satellite source vars should replace the default foreman_ prefix with a custom one when creating host groups. This prefix is not being applied to all groups. Namely, it is missing from the groups we create here:

https://github.com/ansible/awx/blob/devel/awx/main/models/inventory.py#L2605-L2622

ENVIRONMENT
  • AWX version: 11.2.0
  • AWX install method: any
  • Ansible version: 2.9+ (needed to enable use of inv. plugins)
  • Operating System: any
  • Web Browser: any
STEPS TO REPRODUCE
  1. Create a satellite inventory
  2. In inv. source section, set satellite6_group_prefix: newprefix_
  3. Confirm not all groups have new prefix.
EXPECTED RESULTS

All groups use new prefix.

ACTUAL RESULTS

Screen Shot 2020-05-14 at 1 28 34 PM

ADDITIONAL INFORMATION

This section, mentioned in the description, is a part of awx's 'compatibility layer' that bridges the differences between foreman's script and plugin. We need to update this section so that it takes the custom prefix into consideration.

@jladdjr
Copy link
Contributor Author

jladdjr commented May 15, 2020

Have a fix up at #7044. Verified locally and is looking good. Looks like we may be running into some gating issues w/ PRs atm.

@jladdjr
Copy link
Contributor Author

jladdjr commented Jun 5, 2020

The fix for this just got in. (cc @kdelee)

@kdelee
Copy link
Member

kdelee commented Jun 10, 2020

Tested this out manually and it works. Going to work on getting us some regression coverage here, this should be easy to do. Closing as verified will mention issue when I put up PR for tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants