Cannot Launch Workflows if POL enabled but left empty

[unlikelyzero]

ISSUE TYPE

• Bug Report

SUMMARY

Cannot Launch Workflows if POL enabled but left empty

ENVIRONMENT

• AWX version: devel@10/15

STEPS TO REPRODUCE

1. Create a Workflow and enable Prompt on Launch for Limit and SCM Branch
2. Launch Workflow but do not fill in Limit and/or SCM Branch
   Note: Error

EXPECTED RESULTS

If Prompt on Launch enabled, it should not be required

ACTUAL RESULTS

Error thrown

ADDITIONAL INFORMATION

[ryanpetrello]

Do we know if this is a regression? If not, it probably doesn't belong in this milestone.

[mabashian]

I tried this same thing out with a job template and didn't get an error on launch so that got me looking at what might be different between the two scenarios.

For job templates, here's what the OPTIONS response for each of those fields looks like:

            "limit": {
                "type": "string",
                "required": false,
                "label": "Limit",
                "filterable": true,
                "default": ""
            },
            "scm_branch": {
                "type": "string",
                "required": false,
                "label": "Scm branch",
                "help_text": "Branch to use in job run. Project default used if blank. Only allowed if project allow_override field is set to true.",
                "max_length": 1024,
                "filterable": true,
                "default": ""
            },

And for workflow job templates:

            "limit": {
                "type": "string",
                "required": false,
                "label": "Limit",
                "filterable": false,
                "default": null
            },
            "scm_branch": {
                "type": "string",
                "required": false,
                "label": "Scm branch",
                "filterable": false,
                "default": null
            },

Note that the default value for these fields on a job template is an empty string but on a workflow job template it's null. So when we save a workflow job template without a default limit/scm_branch those values are set to null. When the user goes to launch the workflow, if they don't interact with those fields then we pass the default (null) through to the POST params and we hit:

[ryanpetrello]

Talked to @mabashian about this - if there's a simple way to work around it in the UI (i.e., send an empty string, instead of null), that's fine, but if not, I'd say 👎 for now.

Also, @wenottingham @jneedle feel free to convince me I'm wrong, but this doesn't belong in this milestone.

[wenottingham]

See also: #8561