Add button for new inventory source not appearing for inventory admin users

[unixsysadmin]

ISSUE TYPE

• Bug Report

SUMMARY

Add button for new inventory source not appearing for inventory admin users

ENVIRONMENT

• AWX version: 17.0.1
• AWX install method: docker on linux
• Ansible version: 2.9.17
• Operating System: CentOS 8.3
• Web Browser: Firefox

STEPS TO REPRODUCE

• Create an organization
• Add a user to that organization
• Make that user an Inventory Admin, in this case this is achieved via Team Roles

• Create a new inventory as that user
• Navigate to the inventory sources for the inventory
• Add a new inventory source using the 'add' button

EXPECTED RESULTS

The Add button should be displayed to allow you to add the source.

ACTUAL RESULTS

The Add button to allow the additional source is not shown.

ADDITIONAL INFORMATION

When logged in as the 'admin' account to AWX, navigating to the same inventory source page shows the 'Add' button.

Using the AWX 17.0.1 Collection to add an inventory source as the same inventory admin user works successfully, so we know the user has the correct privileges. Sample code:

  - name: Add required inventory sources
    tower_inventory_source:
      name: "{{ item.name }}"
      description: "{{ item.description }}"
      organization: "{{ item.organization }}"
      state: present
      inventory: "{{ item.inventory }}"
      source: "{{ item.source }}"
      source_project: "{{ item.project }}"
      source_path: "{{ item.path }}"
      overwrite: "{{ item.overwrite }}"
      overwrite_vars: "{{ item.overwrite_vars }}"
      update_on_project_update: "{{ item.update_on_project_update }}"
      tower_host: "{{ tower_host }}"
      tower_username: "{{ awx_username }}"
      tower_password: "{{ awx_user_password }}"
    no_log: no
    loop: "{{ inventory_sources }}"

[unlikelyzero]

We will need to add a regression test in this area

[AlexSCorey]

I believe this is an api bug because an options request to /inventory_sources does not return POST for a user that has inventory admin

[kladiv]

+1
UPDATE:

• a team (or user) with "Inventory Admin" role of the Organization should be allowed to create an Inventory Source
• a team (or user) with "Admin" role of the specific Inventory should be allowed to create an Inventory Source

[AlanCoding]

Sorry, I had the wrong info there, was confused looking at inventory vs. inventory source. This may be really simple, see #10372

[thenets]

• Tests passed on latest AWX v̶e̶r̶s̶i̶o̶n̶ build ✅

[kladiv]

is this issue solved in the latest released AWX version?

[thenets]

@kladiv I corrected myself on the comment above. The tests passed on latest build:

• The fixes are available on "devel" branch
• Also, should be available next AWX release