Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send job and template nodes to analytics #6204

Merged
merged 4 commits into from
Apr 22, 2020
Merged

Send job and template nodes to analytics #6204

merged 4 commits into from
Apr 22, 2020

Conversation

Ladas
Copy link
Contributor

@Ladas Ladas commented Mar 6, 2020 •
edited
Loading

SUMMARY

Sending tables main_workflowjobnode and main_workflowjobtemplatenode
containing arrays of success/failure/always_nodes which is compatible
to what API call for nodes return.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME
  • Analytics
IMPLEMENTS FEATURE

#5931

@Ladas Ladas mentioned this pull request Mar 6, 2020
Closed
@Ladas
Copy link
Contributor Author

Ladas commented Mar 6, 2020

@wenottingham @benthomasson @rooftopcellist we'll need to update docs I suppose? Should it be done in this PR? What else is missing?

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@Ladas Ladas mentioned this pull request Mar 18, 2020
Closed
@wenottingham
Copy link
Contributor

Is this dependent on #6176 ?

@Ladas
Copy link
Contributor Author

Ladas commented Apr 8, 2020

@wenottingham it's directly not dependent on #6176. But without that PR, we'd just get nodes and no workflow job records.

@Ladas
Copy link
Contributor Author

Ladas commented Apr 9, 2020

@chrismeyersfsu so right now, there are no indexes on created/modified that I can see. So this will now do a sequential scan. For next major AWX release, it'd be good to add index on some of these columns and use it (Not sure if job nodes record gets updated after the initial create? So the created timestamp might be good here too. )

For backports, the sequential scan might be ok, since the job nodes table might not be that big? (it's smaller than unified jobs)

@chrismeyersfsu
Copy link
Member

@Ladas can you rebase against devel?

@Ladas Ladas force-pushed the send_job_and_template_nodes_to_analytics branch from b3c22af to eaee201 Compare April 9, 2020 16:31
@Ladas
Copy link
Contributor Author

Ladas commented Apr 9, 2020

@chrismeyersfsu rebased

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@Ladas Ladas force-pushed the send_job_and_template_nodes_to_analytics branch from eaee201 to e2257c4 Compare April 14, 2020 08:32
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@wenottingham
Copy link
Contributor

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@wenottingham
Copy link
Contributor

yeah, this needs rebased again after the rsyslog landing

@Ladas Ladas force-pushed the send_job_and_template_nodes_to_analytics branch from e2257c4 to 8cbd4ad Compare April 15, 2020 08:03
@Ladas
Copy link
Contributor Author

Ladas commented Apr 15, 2020

rebased

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@wenottingham
Copy link
Contributor

Sent Ladas#2 for the unit tests.

cc @ryanpetrello @jbradberry @chrismeyersfsu - this is a hack, open to better ideas to work around it.

@Ladas
Copy link
Contributor Author

Ladas commented Apr 16, 2020 •
edited
Loading

@wenottingham I see, the sqlite fails on sqlite3.OperationalError: no such function: ARRAY_AGG

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@chrismeyersfsu
Copy link
Member

chrismeyersfsu commented Apr 16, 2020 •
edited
Loading

@Ladas Tests to be merged in. Then I'm good Ladas#3

@Ladas
Copy link
Contributor Author

Ladas commented Apr 16, 2020

@chrismeyersfsu tests merged. Thank you for that, you're awesome 👍

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@Ladas
Copy link
Contributor Author

Ladas commented Apr 16, 2020

@chrismeyersfsu looks like the tests might be failing? Or is the PR wrong?

@wenottingham
Copy link
Contributor

@chrismeyersfsu @Ladas what needs done here? It looks like it needs rebased at a minimum.

@Ladas
Send job and template nodes to analytics
144cffe 
Sending tables main_workflowjobnode and main_workflowjobtemplatenode
containing arrays of success/failure/always_nodes which is compatible
to what API call for nodes return.
@Ladas Ladas force-pushed the send_job_and_template_nodes_to_analytics branch from 94f299a to 144cffe Compare April 21, 2020 18:02
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@wenottingham wenottingham force-pushed the send_job_and_template_nodes_to_analytics branch from 8d13a1b to 58c821f Compare April 21, 2020 20:32
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@Ladas
Copy link
Contributor Author

Ladas commented Apr 22, 2020

thanks for the test fix @wenottingham , it seems to be ready for merge @chrismeyersfsu

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 4f4a4e2 into ansible:devel Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrismeyersfsu chrismeyersfsu chrismeyersfsu approved these changes

Assignees

@chrismeyersfsu chrismeyersfsu

Labels
component:analytics component:api type:enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Ladas @wenottingham @chrismeyersfsu @AlanCoding @awxbot