Send also workflows as part of unified jobs into analytics

[Ladas]

ISSUE TYPE

• Bug Report

SUMMARY

Workflows are not being sent to analytics (nor other types, e.g. workflow approvals)

Workflows do not have a record in main_job, therefore the JOIN
was ignoring those. We need to do LEFT JOIN to include also
workflows.

ENVIRONMENT

• AWX version: all

STEPS TO REPRODUCE

Send payload to analytics

EXPECTED RESULTS

Workflows and approvals should be part of unified_jobs.csv

ACTUAL RESULTS

Workflows and approvals are not part of the unified_jobs.csv

[Ladas]

Fixed by:
#6176 (sending workflows as part of unified jobs)
#6204 (sending workflow nodes as separate .csv)

[Ladas]

cc @rooftopcellist

[ryanpetrello]

@Ladas I just want to confirm - you've merged everything you need here, right?

[Ladas]

yes, this issue should be fixed now

[kdelee]

Tested this manually and added coverage in our test suite. Calling verified and closing

edit: I tested that workflows and their spawned jobs end up in the unified jobs table csv....missed the part about the PR for the workflow nodes

[kdelee]

woops, https://github.com/ansible/awx/pull/6204/files is not merged!

Workflows now show up in the unified_jobs_table csv file, but the workflow nodes stuff is not there.

[kdelee]

@wenottingham @Ladas are you wanting #6204 to be covered by a different issue?

[wenottingham]

No, we need both for this.

[kdelee]

Linking #5931

[kdelee]

I'm a bit confused. #6204 mentions #5931 but then this issue mentions #6204 .....will #5931 require more work in addition to #6204 ?

[wenottingham]

#5931 requires #6204 and #6201. The PRs are related.

[Ladas]

Sorry for confusion, so not sending workflows (their records from unified_jobs table) was a bug.

Then it's a separate feature to get all workflow data, which includes workflow nodes. :-o

[kdelee]

Ok, everything is now working as expected. Adding some more test coverage downstream