Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add test case for wfj nodes analytics #3

Merged
merged 1 commit into from
Apr 16, 2020
Merged

add test case for wfj nodes analytics #3

merged 1 commit into from
Apr 16, 2020

Conversation

chrismeyersfsu
Copy link

No description provided.

@chrismeyersfsu chrismeyersfsu mentioned this pull request Apr 16, 2020
Merged
Ladas
Ladas reviewed Apr 16, 2020
View reviewed changes
awx/main/tests/functional/analytics/test_collectors.py
@@ -29,6 +32,8 @@ def write_stdout(self, sql, fd):

sql = sql.replace('COPY (', '')
sql = sql.replace(') TO STDOUT WITH CSV HEADER', '')
# sqlite equivalent
sql = sql.replace('ARRAY_AGG', 'GROUP_CONCAT')
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aah, interesting :-D

Ladas
Ladas approved these changes Apr 16, 2020
View reviewed changes
Copy link
Owner

@Ladas Ladas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 awesome

@Ladas Ladas merged commit 94f299a into Ladas:send_job_and_template_nodes_to_analytics Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ladas Ladas Ladas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrismeyersfsu @Ladas