Adding back in missing functionality of Custom Docker Image Builds #9756
Conversation
…support for custom base images/containers. Added back in support for pushing to remote registry. Also added unofficial support in for ppc64le Signed-off-by: James-Crowley <James.Crowley@ibm.com>
|
Build failed.
|
|
@vielmetti If you get the chance, do you mind confirming that |
| # Helper vars to construct the proper multi-arch configuration | ||
| tini_architecture: '{{ { "x86_64": "amd64", "aarch64": "arm64", "armv7": "arm", "ppc64le": "ppc64le" }[ansible_facts.architecture] }}' | ||
| kubectl_architecture: '{{ { "x86_64": "amd64", "aarch64": "arm64", "armv7": "arm", "ppc64le": "ppc64le" }[ansible_facts.architecture] }}' | ||
| base_container: '{{ { "x86_64": "centos:8", "aarch64": "centos:8", "armv7": "centos:8", "ppc64le": "centos:8" }[ansible_facts.architecture] }}' |
There was a problem hiding this comment.
For base_container, why use a mapping if all keys point to the same container image?
There was a problem hiding this comment.
@jakemcdermott This is to allow for other architectures that do not have centos:8 available, notably s390x. In my testing, I was able to add an entry into the map here that looked something like:
"s390x": "fedora:32"
Which thus allowed me to build custom images for s390x. The reason I did not add s390x into the existing map is it requires other jinja edits in the Dockerfile template. I was going to do some more testing and do a PR later to add in unofficial support for s390x. But I thought adding in the base_container variable is useful right now for others.
There was a problem hiding this comment.
You can see some of the smaller edits I backed ported into 17.1.0 to add s390x support here.
There was a problem hiding this comment.
@jakemcdermott Are you fine with this addition?
Signed-off-by: James-Crowley <James.Crowley@ibm.com>
|
Build succeeded.
|
|
Hello. If you could please rebase and resolve the conflict, we can merge this. |
|
Closing due to lack of response. |
SUMMARY
With the switch to 18.0, the removal of local docker install was removed. During this shuffle of code, it looks like some functionality was dropped. This PR aims to add back in that functionality. Plus add unofficial support for ppc64le like there is for arm64.
ISSUE TYPE
COMPONENT NAME
AWX VERSION
ADDITIONAL INFORMATION
The functionality that was delete/shifted was:
New Stuff Added:
centos:8, you could swap it forfedoraor something similar)