-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Local Docker Install with Community Docker-Compose #9289
Replace Local Docker Install with Community Docker-Compose #9289
Conversation
@rooftopcellist let me know or @tiagodread when this is available to test. |
e1ceedf
to
5d6a582
Compare
f9271b1
to
562cfce
Compare
415ec22
to
90c66e2
Compare
310bc66
to
7be4358
Compare
7be4358
to
7a80da8
Compare
I gave this a whirl by wiping out my local Docker, installing a 17.0.1 and attempting an upgrade: ~ git fetch upstream && git checkout 17.0.1
~ git reset --hard upstream/17.0.1
~ (tags/17.0.1:●●) ~/dev/awx/installer ansible-playbook -i inventory install.yml Next, I ran some playbooks in 17.0.1: Next, I cloned @rooftopcellist's branch, and ran the migration script: ~/dev/awx/tools/docker-compose/ansible ansible-playbook migrate.yml -e "migrate_local_docker=true" -e "postgres_data_dir=~/.awx/pgdocker" -e "old_docker_compose_dir=~/.awx/awxcompose" ...and finally, I started the new development environment: ~/dev/awx COMPOSE_TAG=devel make docker-compose-test |
7a80da8
to
af6af05
Compare
Build succeeded.
|
- Also, do no explicitly name containers
4ea35d8
to
b583aeb
Compare
Build succeeded.
|
Okay @rooftopcellist I just tried again. 17.0.1 install w/ a job I ran: (tags/17.0.1:●●) ~/dev/awx/installer docker ps -a
CONTAINER ID IMAGE COMMAND CREATED STATUS PORTS NAMES
d26c174de61d ansible/awx:17.0.1 "/usr/bin/tini -- /u…" 11 minutes ago Up 11 minutes 8052/tcp awx_task
30443e803858 ansible/awx:17.0.1 "/usr/bin/tini -- /b…" 13 minutes ago Up 11 minutes 0.0.0.0:80->8052/tcp awx_web
2c66c1a88f45 postgres:12 "docker-entrypoint.s…" 13 minutes ago Up 11 minutes 5432/tcp awx_postgres
e62d29f57fb3 redis "docker-entrypoint.s…" 13 minutes ago Up 11 minutes 6379/tcp awx_redis Next, I cloned your branch and ran the Post-upgrade: ~ docker volume ls | grep awx_db && docker ps -a
local tools_awx_db
CONTAINER ID IMAGE COMMAND CREATED STATUS PORTS NAMES
870dacb3c43e postgres:12 "docker-entrypoint.s…" 38 seconds ago Up 37 seconds 5432/tcp tools_postgres_1 Now, after a
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this and migration worked for me following the instructions from a 17.0.1 Docker install (as expected, I had to create an admin user and create preload data myself post-install).
I was also able to do a fresh image build and make docker-compose
from this branch and see a fresh AWX install come up.
cc @shanemcd for any additional code review he may wish to do.
Build failed (gate pipeline). For information on how to proceed, see
|
regate |
Build succeeded (gate pipeline).
|
Issue: #9125
Initial WIP PR for Replacing the Local Docker installation with a docker-compose method close to what we do for the development environment.
ISSUE TYPE
COMPONENT NAME
AWX VERSION
ADDITIONAL INFORMATION