-
Notifications
You must be signed in to change notification settings - Fork 144
Module Maintainer Guidelines #81
Comments
See also #5 |
3:04 PM What's #81 for? |
Also, link amazon guidelines, other magic in here. |
Also useful to note in such things, maybe: "give your new module PR a clear title, since people may see it in the weekly new module report and if it's a thing that interests them, they may be more inclined to test it if what it's for is super clear" |
First draft ETA... soonish. :) |
The 'by file' page would be super useful to link to in boilerplate comments to prs. The bot can extract the touched files and find the module and maintainers already. Can't tell if there are anchor links available for https://ansible.sivel.net/pr/byfile.html, but if there are, the comment could point to other prs that touch the same files. (ditto for issuebot, once it has some filename/module/maintainer capabilities...) |
https://github.com/robynbergeron/thingsandstuff/blob/master/MODULEMAINTAINERS.md Okay, here's a rough first cut (making sure i'm on the right track here). |
Yes. Definitely the right track. |
OK, so we now have this: https://github.com/ansible/ansible-modules-extras/blob/devel/MAINTAINERS.md And next we should:
|
Add this somehow: https://github.com/ansible/community/blob/master/PR-FLOW.md |
Okay, I've updated this -- albeit in my repo, before merging it to extras/maintainers.md, so everyone can take an eyeball in today's meeting and we can merge / fix as needed then. https://github.com/robynbergeron/thingsandstuff/blob/master/MODULEMAINTAINERS.md I think I've covered the aforementioned needed updates -- the lone question I have outstanding is whether or not we want to update Contributing.MD with the suggested forked version linked by Adrian in the previous comment (https://github.com/alikins/ansible-modules-extras/commit/c87795da5b0c95c67fea1608a5a2a4ec54cb3905) and simply link to that from Maintainers.md -- or if we want to just merge that part into maintainers.md IMO: Probably better to merge it into contributors.md -- since we do have lots of PRs for modules from folks who are not maintainers, but still need to adhere to those guidelines in order for their PRs to be merged. But I'm open to suggestions, as always. :) |
Next steps:
|
To be clear:
So that's what we'll do. And then we'll get rid of "extras/MAINTAINERS.md". |
Need to:
|
We'll check in the latest and keep iterating according to your latest. |
Added to our little hackfest time plan for tomorrow (thurs. 9/8) |
I think we're finally done with this one, hooray! |
https://ansible.sivel.net/pr/byfile.html
The text was updated successfully, but these errors were encountered: