Workflow to setup Windows Domain with DC and hosts #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jce-redhat
reviewed
Aug 14, 2024
collections/ansible_collections/demo/cloud/roles/aws/tasks/create_vm.yml
Outdated
Show resolved
Hide resolved
collections/ansible_collections/demo/cloud/roles/aws/templates/aws_windows_userdata.j2
Outdated
Show resolved
Hide resolved
|
Latest success - running E2E after @jce-redhat consolidation to common |
bbethell-1
approved these changes
Aug 22, 2024
jce-redhat
reviewed
Aug 28, 2024
| gather_facts: false | ||
|
|
||
| tasks: | ||
| - name: Wait 600 seconds for target connection to become reachable/usable |
There was a problem hiding this comment.
cosmetic: task says 600 seconds but default value in the task is 300
Comment on lines
+10
to
+11
| delay: "{{ wait_for_delay_sec | default(0) }}" | ||
| sleep: "{{ wait_for_sleep_sec | default(1) }}" |
There was a problem hiding this comment.
if you know the initial connection after building the systems will take a while, you might want to increase the delay default to what you think the minimum time would be. i'd suggest also increasing the sleep default to 5 or 10 just to reduce the connection load on the system.
| ## Suggested Usage | ||
|
|
||
| **Setup Active Directory Domain** - One-click domain setup, infrastructure included. |
There was a problem hiding this comment.
what is meant by "infrastructure included?"
| type: multiplechoice | ||
| variable: create_vm_aws_region | ||
| required: true | ||
| default: us-east-2 |
There was a problem hiding this comment.
in other surveys i don't think we set a default for AWS region, but i like the idea so i'll put in an issue to do so.
jce-redhat
approved these changes
Aug 29, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change includes a workflow to provide users a small Windows domain with a domain controller and two windows hosts. The added workflow leverages pre-existing job templates from the cloud and windows content: